Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

staging: rtlwifi: make various structures static

The structures created from macros RTL_DEBUG_IMPL_MAC_SERIES,
RTL_DEBUG_IMPL_BB_SERIES, RTL_DEBUG_IMPL_RF_SERIES and
RTL_DEBUG_IMPL_CAM_SERIES are all local to the source and do
not need to be in global scope, so make them static.

Cleans up 37 sparse warnings of the form:
symbol 'rtl_debug_priv_mac_0' was not declared. Should it be static?

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

authored by

Colin Ian King and committed by
Greg Kroah-Hartman
b9fd63ea cfc70e7c

+16 -16
+16 -16
drivers/staging/rtlwifi/debug.c
··· 127 127 return 0; 128 128 } 129 129 130 - #define RTL_DEBUG_IMPL_MAC_SERIES(page, addr) \ 131 - struct rtl_debugfs_priv rtl_debug_priv_mac_ ##page = { \ 132 - .cb_read = rtl_debug_get_mac_page, \ 133 - .cb_data = addr, \ 130 + #define RTL_DEBUG_IMPL_MAC_SERIES(page, addr) \ 131 + static struct rtl_debugfs_priv rtl_debug_priv_mac_ ##page = { \ 132 + .cb_read = rtl_debug_get_mac_page, \ 133 + .cb_data = addr, \ 134 134 } 135 135 136 136 RTL_DEBUG_IMPL_MAC_SERIES(0, 0x0000); ··· 169 169 return 0; 170 170 } 171 171 172 - #define RTL_DEBUG_IMPL_BB_SERIES(page, addr) \ 173 - struct rtl_debugfs_priv rtl_debug_priv_bb_ ##page = { \ 174 - .cb_read = rtl_debug_get_bb_page, \ 175 - .cb_data = addr, \ 172 + #define RTL_DEBUG_IMPL_BB_SERIES(page, addr) \ 173 + static struct rtl_debugfs_priv rtl_debug_priv_bb_ ##page = { \ 174 + .cb_read = rtl_debug_get_bb_page, \ 175 + .cb_data = addr, \ 176 176 } 177 177 178 178 RTL_DEBUG_IMPL_BB_SERIES(8, 0x0800); ··· 216 216 return 0; 217 217 } 218 218 219 - #define RTL_DEBUG_IMPL_RF_SERIES(page, addr) \ 220 - struct rtl_debugfs_priv rtl_debug_priv_rf_ ##page = { \ 221 - .cb_read = rtl_debug_get_reg_rf, \ 222 - .cb_data = addr, \ 219 + #define RTL_DEBUG_IMPL_RF_SERIES(page, addr) \ 220 + static struct rtl_debugfs_priv rtl_debug_priv_rf_ ##page = { \ 221 + .cb_read = rtl_debug_get_reg_rf, \ 222 + .cb_data = addr, \ 223 223 } 224 224 225 225 RTL_DEBUG_IMPL_RF_SERIES(a, RF90_PATH_A); ··· 271 271 return 0; 272 272 } 273 273 274 - #define RTL_DEBUG_IMPL_CAM_SERIES(page, addr) \ 275 - struct rtl_debugfs_priv rtl_debug_priv_cam_ ##page = { \ 276 - .cb_read = rtl_debug_get_cam_register, \ 277 - .cb_data = addr, \ 274 + #define RTL_DEBUG_IMPL_CAM_SERIES(page, addr) \ 275 + static struct rtl_debugfs_priv rtl_debug_priv_cam_ ##page = { \ 276 + .cb_read = rtl_debug_get_cam_register, \ 277 + .cb_data = addr, \ 278 278 } 279 279 280 280 RTL_DEBUG_IMPL_CAM_SERIES(1, 0);