Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

media: go7007: fix a memleak in go7007_load_encoder

In go7007_load_encoder, bounce(i.e. go->boot_fw), is allocated without
a deallocation thereafter. After the following call chain:

saa7134_go7007_init
|-> go7007_boot_encoder
|-> go7007_load_encoder
|-> kfree(go)

go is freed and thus bounce is leaked.

Fixes: 95ef39403f89 ("[media] go7007: remember boot firmware")
Signed-off-by: Zhipeng Lu <alexious@zju.edu.cn>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>

authored by

Zhipeng Lu and committed by
Hans Verkuil
b9b68384 7a4cf27d

+5 -3
+5 -3
drivers/media/usb/go7007/go7007-driver.c
··· 80 80 const struct firmware *fw_entry; 81 81 char fw_name[] = "go7007/go7007fw.bin"; 82 82 void *bounce; 83 - int fw_len, rv = 0; 83 + int fw_len; 84 84 u16 intr_val, intr_data; 85 85 86 86 if (go->boot_fw == NULL) { ··· 109 109 go7007_read_interrupt(go, &intr_val, &intr_data) < 0 || 110 110 (intr_val & ~0x1) != 0x5a5a) { 111 111 v4l2_err(go, "error transferring firmware\n"); 112 - rv = -1; 112 + kfree(go->boot_fw); 113 + go->boot_fw = NULL; 114 + return -1; 113 115 } 114 - return rv; 116 + return 0; 115 117 } 116 118 117 119 MODULE_FIRMWARE("go7007/go7007fw.bin");