Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

iio: adc: ad7266: Fix alignment for DMA safety

____cacheline_aligned is an insufficient guarantee for non-coherent DMA
on platforms with 128 byte cachelines above L1. Switch to the updated
IIO_DMA_MINALIGN definition.

Update the comment to reflect that DMA safety 'may' require separate
cachelines.

Fixes: 54e018da3141 ("iio:ad7266: Mark transfer buffer as __be16")
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Acked-by: Nuno Sá <nuno.sa@analog.com>
Link: https://lore.kernel.org/r/20220508175712.647246-10-jic23@kernel.org

+2 -2
+2 -2
drivers/iio/adc/ad7266.c
··· 37 37 struct gpio_desc *gpios[3]; 38 38 39 39 /* 40 - * DMA (thus cache coherency maintenance) requires the 40 + * DMA (thus cache coherency maintenance) may require the 41 41 * transfer buffers to live in their own cache lines. 42 42 * The buffer needs to be large enough to hold two samples (4 bytes) and 43 43 * the naturally aligned timestamp (8 bytes). ··· 45 45 struct { 46 46 __be16 sample[2]; 47 47 s64 timestamp; 48 - } data ____cacheline_aligned; 48 + } data __aligned(IIO_DMA_MINALIGN); 49 49 }; 50 50 51 51 static int ad7266_wakeup(struct ad7266_state *st)