Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

media: dvb-usb-v2: gl861: Fix null-ptr-deref in gl861_i2c_master_xfer

In gl861_i2c_master_xfer, msg is controlled by user. When msg[i].buf
is null and msg[i].len is zero, former checks on msg[i].buf would be
passed. Malicious data finally reach gl861_i2c_master_xfer. If accessing
msg[i].buf[0] without sanity check, null ptr deref would happen.
We add check on msg[i].len to prevent crash.

Similar commit:
commit 0ed554fd769a
("media: dvb-usb: az6027: fix null-ptr-deref in az6027_i2c_xfer()")

Signed-off-by: Zhang Shurong <zhang_shurong@foxmail.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>

authored by

Zhang Shurong and committed by
Hans Verkuil
b97719a6 f7e0f1f5

+1 -1
+1 -1
drivers/media/usb/dvb-usb-v2/gl861.c
··· 120 120 } else if (num == 2 && !(msg[0].flags & I2C_M_RD) && 121 121 (msg[1].flags & I2C_M_RD)) { 122 122 /* I2C write + read */ 123 - if (msg[0].len > 1 || msg[1].len > sizeof(ctx->buf)) { 123 + if (msg[0].len != 1 || msg[1].len > sizeof(ctx->buf)) { 124 124 ret = -EOPNOTSUPP; 125 125 goto err; 126 126 }