Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

x86/mm/pti: Introduce pti_finalize()

Introduce a new function to finalize the kernel mappings for the userspace
page-table after all ro/nx protections have been applied to the kernel
mappings.

Also move the call to pti_clone_kernel_text() to that function so that it
will run on 32 bit kernels too.

Signed-off-by: Joerg Roedel <jroedel@suse.de>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Tested-by: Pavel Machek <pavel@ucw.cz>
Cc: "H . Peter Anvin" <hpa@zytor.com>
Cc: linux-mm@kvack.org
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Andy Lutomirski <luto@kernel.org>
Cc: Dave Hansen <dave.hansen@intel.com>
Cc: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Juergen Gross <jgross@suse.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Jiri Kosina <jkosina@suse.cz>
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: Brian Gerst <brgerst@gmail.com>
Cc: David Laight <David.Laight@aculab.com>
Cc: Denys Vlasenko <dvlasenk@redhat.com>
Cc: Eduardo Valentin <eduval@amazon.com>
Cc: Greg KH <gregkh@linuxfoundation.org>
Cc: Will Deacon <will.deacon@arm.com>
Cc: aliguori@amazon.com
Cc: daniel.gruss@iaik.tugraz.at
Cc: hughd@google.com
Cc: keescook@google.com
Cc: Andrea Arcangeli <aarcange@redhat.com>
Cc: Waiman Long <llong@redhat.com>
Cc: "David H . Gutteridge" <dhgutteridge@sympatico.ca>
Cc: joro@8bytes.org
Link: https://lkml.kernel.org/r/1531906876-13451-30-git-send-email-joro@8bytes.org

authored by

Joerg Roedel and committed by
Thomas Gleixner
b976690f 1ac228a7

+22 -9
+1 -2
arch/x86/include/asm/pti.h
··· 6 6 #ifdef CONFIG_PAGE_TABLE_ISOLATION 7 7 extern void pti_init(void); 8 8 extern void pti_check_boottime_disable(void); 9 - extern void pti_clone_kernel_text(void); 9 + extern void pti_finalize(void); 10 10 #else 11 11 static inline void pti_check_boottime_disable(void) { } 12 - static inline void pti_clone_kernel_text(void) { } 13 12 #endif 14 13 15 14 #endif /* __ASSEMBLY__ */
-6
arch/x86/mm/init_64.c
··· 1291 1291 (unsigned long) __va(__pa_symbol(_sdata))); 1292 1292 1293 1293 debug_checkwx(); 1294 - 1295 - /* 1296 - * Do this after all of the manipulation of the 1297 - * kernel text page tables are complete. 1298 - */ 1299 - pti_clone_kernel_text(); 1300 1294 } 1301 1295 1302 1296 int kern_addr_valid(unsigned long addr)
+13 -1
arch/x86/mm/pti.c
··· 462 462 * For some configurations, map all of kernel text into the user page 463 463 * tables. This reduces TLB misses, especially on non-PCID systems. 464 464 */ 465 - void pti_clone_kernel_text(void) 465 + static void pti_clone_kernel_text(void) 466 466 { 467 467 /* 468 468 * rodata is part of the kernel image and is normally ··· 525 525 pti_clone_entry_text(); 526 526 pti_setup_espfix64(); 527 527 pti_setup_vsyscall(); 528 + } 529 + 530 + /* 531 + * Finalize the kernel mappings in the userspace page-table. 532 + */ 533 + void pti_finalize(void) 534 + { 535 + /* 536 + * Do this after all of the manipulation of the 537 + * kernel text page tables are complete. 538 + */ 539 + pti_clone_kernel_text(); 528 540 }
+1
include/linux/pti.h
··· 6 6 #include <asm/pti.h> 7 7 #else 8 8 static inline void pti_init(void) { } 9 + static inline void pti_finalize(void) { } 9 10 #endif 10 11 11 12 #endif
+7
init/main.c
··· 1065 1065 jump_label_invalidate_initmem(); 1066 1066 free_initmem(); 1067 1067 mark_readonly(); 1068 + 1069 + /* 1070 + * Kernel mappings are now finalized - update the userspace page-table 1071 + * to finalize PTI. 1072 + */ 1073 + pti_finalize(); 1074 + 1068 1075 system_state = SYSTEM_RUNNING; 1069 1076 numa_default_policy(); 1070 1077