firewire: small fw_fill_request cleanup

- better name for a function argument
- removal of a local variable which became unnecessary after
"fully initialize fw_transaction before marking it pending"

Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>

+5 -7
+5 -7
drivers/firewire/fw-transaction.c
··· 151 151 152 152 static void 153 153 fw_fill_request(struct fw_packet *packet, int tcode, int tlabel, 154 - int node_id, int source_id, int generation, int speed, 154 + int destination_id, int source_id, int generation, int speed, 155 155 unsigned long long offset, void *payload, size_t length) 156 156 { 157 157 int ext_tcode; ··· 166 166 HEADER_RETRY(RETRY_X) | 167 167 HEADER_TLABEL(tlabel) | 168 168 HEADER_TCODE(tcode) | 169 - HEADER_DESTINATION(node_id); 169 + HEADER_DESTINATION(destination_id); 170 170 packet->header[1] = 171 171 HEADER_OFFSET_HIGH(offset >> 32) | HEADER_SOURCE(source_id); 172 172 packet->header[2] = ··· 252 252 fw_transaction_callback_t callback, void *callback_data) 253 253 { 254 254 unsigned long flags; 255 - int tlabel, source; 255 + int tlabel; 256 256 257 257 /* 258 258 * Bump the flush timer up 100ms first of all so we ··· 268 268 269 269 spin_lock_irqsave(&card->lock, flags); 270 270 271 - source = card->node_id; 272 271 tlabel = card->current_tlabel; 273 272 if (card->tlabel_mask & (1 << tlabel)) { 274 273 spin_unlock_irqrestore(&card->lock, flags); ··· 283 284 t->callback = callback; 284 285 t->callback_data = callback_data; 285 286 286 - fw_fill_request(&t->packet, tcode, t->tlabel, 287 - node_id, source, generation, 288 - speed, offset, payload, length); 287 + fw_fill_request(&t->packet, tcode, t->tlabel, node_id, card->node_id, 288 + generation, speed, offset, payload, length); 289 289 t->packet.callback = transmit_complete_callback; 290 290 291 291 list_add_tail(&t->link, &card->transaction_list);