Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

net: wangxun: move PHYLINK dependency

The LIBWX library code is what calls into phylink, so any user of
it has to select CONFIG_PHYLINK at the moment, with NGBEVF missing this:

x86_64-linux-ld: drivers/net/ethernet/wangxun/libwx/wx_ethtool.o: in function `wx_nway_reset':
wx_ethtool.c:(.text+0x613): undefined reference to `phylink_ethtool_nway_reset'
x86_64-linux-ld: drivers/net/ethernet/wangxun/libwx/wx_ethtool.o: in function `wx_get_link_ksettings':
wx_ethtool.c:(.text+0x62b): undefined reference to `phylink_ethtool_ksettings_get'
x86_64-linux-ld: drivers/net/ethernet/wangxun/libwx/wx_ethtool.o: in function `wx_set_link_ksettings':
wx_ethtool.c:(.text+0x643): undefined reference to `phylink_ethtool_ksettings_set'
x86_64-linux-ld: drivers/net/ethernet/wangxun/libwx/wx_ethtool.o: in function `wx_get_pauseparam':
wx_ethtool.c:(.text+0x65b): undefined reference to `phylink_ethtool_get_pauseparam'
x86_64-linux-ld: drivers/net/ethernet/wangxun/libwx/wx_ethtool.o: in function `wx_set_pauseparam':
wx_ethtool.c:(.text+0x677): undefined reference to `phylink_ethtool_set_pauseparam'

Add the 'select PHYLINK' line in the libwx option directly so this will
always be enabled for all current and future wangxun drivers, and remove
the now duplicate lines.

Fixes: a0008a3658a3 ("net: wangxun: add ngbevf build")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Vadim Fedorenko <vadim.fedorenko@linux.dev>
Link: https://patch.msgid.link/20251216213547.115026-1-arnd@kernel.org
Signed-off-by: Paolo Abeni <pabeni@redhat.com>

authored by

Arnd Bergmann and committed by
Paolo Abeni
b94f11af 472c5dd6

+1 -3
+1 -3
drivers/net/ethernet/wangxun/Kconfig
··· 21 21 depends on PTP_1588_CLOCK_OPTIONAL 22 22 select PAGE_POOL 23 23 select DIMLIB 24 + select PHYLINK 24 25 help 25 26 Common library for Wangxun(R) Ethernet drivers. 26 27 ··· 30 29 depends on PCI 31 30 depends on PTP_1588_CLOCK_OPTIONAL 32 31 select LIBWX 33 - select PHYLINK 34 32 help 35 33 This driver supports Wangxun(R) GbE PCI Express family of 36 34 adapters. ··· 48 48 depends on PTP_1588_CLOCK_OPTIONAL 49 49 select MARVELL_10G_PHY 50 50 select REGMAP 51 - select PHYLINK 52 51 select HWMON if TXGBE=y 53 52 select SFP 54 53 select GPIOLIB ··· 70 71 depends on PCI_MSI 71 72 depends on PTP_1588_CLOCK_OPTIONAL 72 73 select LIBWX 73 - select PHYLINK 74 74 help 75 75 This driver supports virtual functions for SP1000A, WX1820AL, 76 76 WX5XXX, WX5XXXAL.