Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

fbdev: Make drivers depend on FB_TILEBLITTING

The option CONFIG_FB_TILEBLITTING is controlled by the user. Selecting
it from drivers can lead to cyclic dependencies within the config. In
fbcon, there's special handling for tile blitting, which currently
cannot be disabled without first disabling the relevant fbdev drivers.
Fix the Kconfig dependency to make it work.

Some guidelines for using select can be found in the kernel docs at [1].

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Link: https://elixir.bootlin.com/linux/v6.16/source/Documentation/kbuild/kconfig-language.rst#L147 # [1]
Acked-by: Arnd Bergmann <arnd@arndb.de>
Link: https://lore.kernel.org/r/20250909132047.152612-2-tzimmermann@suse.de

+4 -4
+4 -4
drivers/video/fbdev/Kconfig
··· 816 816 config FB_MATROX 817 817 tristate "Matrox acceleration" 818 818 depends on FB && PCI 819 + depends on FB_TILEBLITTING 819 820 select FB_CFB_FILLRECT 820 821 select FB_CFB_COPYAREA 821 822 select FB_CFB_IMAGEBLIT 822 823 select FB_IOMEM_FOPS 823 - select FB_TILEBLITTING 824 824 select FB_MACMODES if PPC_PMAC 825 825 help 826 826 Say Y here if you have a Matrox Millennium, Matrox Millennium II, ··· 1053 1053 config FB_S3 1054 1054 tristate "S3 Trio/Virge support" 1055 1055 depends on FB && PCI && HAS_IOPORT 1056 + depends on FB_TILEBLITTING 1056 1057 select FB_CFB_FILLRECT 1057 1058 select FB_CFB_COPYAREA 1058 1059 select FB_CFB_IMAGEBLIT 1059 1060 select FB_IOMEM_FOPS 1060 - select FB_TILEBLITTING 1061 1061 select FB_SVGALIB 1062 1062 select VGASTATE 1063 1063 select FONT_8x16 if FRAMEBUFFER_CONSOLE ··· 1258 1258 config FB_VT8623 1259 1259 tristate "VIA VT8623 support" 1260 1260 depends on FB && PCI && HAS_IOPORT 1261 + depends on FB_TILEBLITTING 1261 1262 select FB_CFB_FILLRECT 1262 1263 select FB_CFB_COPYAREA 1263 1264 select FB_CFB_IMAGEBLIT 1264 1265 select FB_IOMEM_FOPS 1265 - select FB_TILEBLITTING 1266 1266 select FB_SVGALIB 1267 1267 select VGASTATE 1268 1268 select FONT_8x16 if FRAMEBUFFER_CONSOLE ··· 1296 1296 config FB_ARK 1297 1297 tristate "ARK 2000PV support" 1298 1298 depends on FB && PCI && HAS_IOPORT 1299 + depends on FB_TILEBLITTING 1299 1300 select FB_CFB_FILLRECT 1300 1301 select FB_CFB_COPYAREA 1301 1302 select FB_CFB_IMAGEBLIT 1302 1303 select FB_IOMEM_FOPS 1303 - select FB_TILEBLITTING 1304 1304 select FB_SVGALIB 1305 1305 select VGASTATE 1306 1306 select FONT_8x16 if FRAMEBUFFER_CONSOLE