Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

drivers/perf: kill armpmu_register

Nothing outside of drivers/perf/arm_pmu.c should call armpmu_register
any more, so it no longer needs to be in include/linux/perf/arm_pmu.h.
Additionally, by folding it in to arm_pmu_device_probe we can allow
drivers to override struct pmu fields without getting blatted by the
armpmu code.

This patch folds armpmu_register into arm_pmu_device_probe. The logging
to the console is moved to after the PMU is successfully registered with
the core perf code.

Signed-off-by: Mark Rutland <mark.rutland@arm.com>
Suggested-by: Will Deacon <will.deacon@arm.com>
Cc: Drew Richardson <drew.richardson@arm.com>
Cc: Pawel Moll <pawel.moll@arm.com>
Signed-off-by: Will Deacon <will.deacon@arm.com>

authored by

Mark Rutland and committed by
Will Deacon
b916b785 8005c49d

+6 -11
+6 -9
drivers/perf/arm_pmu.c
··· 551 551 }; 552 552 } 553 553 554 - int armpmu_register(struct arm_pmu *armpmu, int type) 555 - { 556 - armpmu_init(armpmu); 557 - pr_info("enabled with %s PMU driver, %d counters available\n", 558 - armpmu->name, armpmu->num_events); 559 - return perf_pmu_register(&armpmu->pmu, armpmu->name, type); 560 - } 561 - 562 554 /* Set at runtime when we know what CPU type we are. */ 563 555 static struct arm_pmu *__oprofile_cpu_pmu; 564 556 ··· 879 887 return -ENOMEM; 880 888 } 881 889 890 + armpmu_init(pmu); 891 + 882 892 if (!__oprofile_cpu_pmu) 883 893 __oprofile_cpu_pmu = pmu; 884 894 ··· 906 912 if (ret) 907 913 goto out_free; 908 914 909 - ret = armpmu_register(pmu, -1); 915 + ret = perf_pmu_register(&pmu->pmu, pmu->name, -1); 910 916 if (ret) 911 917 goto out_destroy; 918 + 919 + pr_info("enabled with %s PMU driver, %d counters available\n", 920 + pmu->name, pmu->num_events); 912 921 913 922 return 0; 914 923
-2
include/linux/perf/arm_pmu.h
··· 111 111 112 112 #define to_arm_pmu(p) (container_of(p, struct arm_pmu, pmu)) 113 113 114 - int armpmu_register(struct arm_pmu *armpmu, int type); 115 - 116 114 u64 armpmu_event_update(struct perf_event *event); 117 115 118 116 int armpmu_event_set_period(struct perf_event *event);