Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

samples/hw_breakpoint: fix building without module unloading

__symbol_put() is really meant as an internal helper and is not available
when module unloading is disabled, unlike the previously used symbol_put():

samples/hw_breakpoint/data_breakpoint.c: In function 'hw_break_module_exit':
samples/hw_breakpoint/data_breakpoint.c:73:9: error: implicit declaration of function '__symbol_put'; did you mean '__symbol_get'? [-Werror=implicit-function-declaration]

The hw_break_module_exit() function is not actually used when module
unloading is disabled, but it still causes the build failure for an
undefined identifier. Enclose this one call in an appropriate #ifdef to
clarify what the requirement is. Leaving out the entire exit function
would also work but feels less clar in this case.

Fixes: 910e230d5f1bb ("samples/hw_breakpoint: Fix kernel BUG 'invalid opcode: 0000'")
Fixes: d8a84d33a4954 ("samples/hw_breakpoint: drop use of kallsyms_lookup_name()")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Petr Mladek <pmladek@suse.com>
Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>

authored by

Arnd Bergmann and committed by
Luis Chamberlain
b9080468 910e230d

+2
+2
samples/hw_breakpoint/data_breakpoint.c
··· 70 70 static void __exit hw_break_module_exit(void) 71 71 { 72 72 unregister_wide_hw_breakpoint(sample_hbp); 73 + #ifdef CONFIG_MODULE_UNLOAD 73 74 __symbol_put(ksym_name); 75 + #endif 74 76 printk(KERN_INFO "HW Breakpoint for %s write uninstalled\n", ksym_name); 75 77 } 76 78