Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

fbdev/valkyriefb: Use fbdev I/O helpers

Set struct fb_ops and with FB_DEFAULT_IOMEM_OPS, fbdev's initializer
for I/O memory. Sets the callbacks to the cfb_ and fb_io_ functions.
Select the correct modules with Kconfig's FB_IOMEM_HELPERS token.

The macro and token set the currently selected values, so there is
no functional change.

v3:
* use _IOMEM_ in commit message
v2:
* updated to use _IOMEM_ tokens

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
Acked-by: Helge Deller <deller@gmx.de>
Link: https://patchwork.freedesktop.org/patch/msgid/20230803184034.6456-45-tzimmermann@suse.de

+2 -6
+1 -3
drivers/video/fbdev/Kconfig
··· 328 328 config FB_VALKYRIE 329 329 bool "Apple \"valkyrie\" display support" 330 330 depends on (FB = y) && (MAC || (PPC_PMAC && PPC32)) 331 - select FB_CFB_FILLRECT 332 - select FB_CFB_COPYAREA 333 - select FB_CFB_IMAGEBLIT 331 + select FB_IOMEM_HELPERS 334 332 select FB_MACMODES 335 333 help 336 334 This driver supports a frame buffer for the "valkyrie" graphics
+1 -3
drivers/video/fbdev/valkyriefb.c
··· 110 110 111 111 static const struct fb_ops valkyriefb_ops = { 112 112 .owner = THIS_MODULE, 113 + FB_DEFAULT_IOMEM_OPS, 113 114 .fb_check_var = valkyriefb_check_var, 114 115 .fb_set_par = valkyriefb_set_par, 115 116 .fb_setcolreg = valkyriefb_setcolreg, 116 117 .fb_blank = valkyriefb_blank, 117 - .fb_fillrect = cfb_fillrect, 118 - .fb_copyarea = cfb_copyarea, 119 - .fb_imageblit = cfb_imageblit, 120 118 }; 121 119 122 120 /* Sets the video mode according to info->var */