Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

dm-table: Set BLK_FEAT_ATOMIC_WRITES for target queue limits

Feature flag BLK_FEAT_ATOMIC_WRITES is not being properly set for the
target queue limits, and this means that atomic writes are not being
enabled for any dm personalities.

When calling dm_set_device_limits() -> blk_stack_limits() ->
... -> blk_stack_atomic_writes_limits(), the bottom device limits
(which corresponds to intermediate target queue limits) does not have
BLK_FEAT_ATOMIC_WRITES set, and so atomic writes can never be enabled.

Typically such a flag would be inherited from the stacked device in
dm_set_device_limits() -> blk_stack_limits() via BLK_FEAT_INHERIT_MASK,
but BLK_FEAT_ATOMIC_WRITES is not inherited as it's preferred to manually
enable on a per-personality basis.

Set BLK_FEAT_ATOMIC_WRITES manually for the intermediate target queue
limits from the stacked device to get atomic writes working.

Fixes: 3194e36488e2 ("dm-table: atomic writes support")
Cc: stable@vger.kernel.org # v6.14
Signed-off-by: John Garry <john.g.garry@oracle.com>
Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>

authored by

John Garry and committed by
Mikulas Patocka
b7c18b17 7734fb4a

+6
+6
drivers/md/dm-table.c
··· 430 430 return 0; 431 431 } 432 432 433 + /* 434 + * BLK_FEAT_ATOMIC_WRITES is not inherited from the bottom device in 435 + * blk_stack_limits(), so do it manually. 436 + */ 437 + limits->features |= (q->limits.features & BLK_FEAT_ATOMIC_WRITES); 438 + 433 439 mutex_lock(&q->limits_lock); 434 440 if (blk_stack_limits(limits, &q->limits, 435 441 get_start_sect(bdev) + start) < 0)