Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

PCI/switchtec: Declare local state_names[] as static

The local state_names[] array is constant and need not be allocated and
populated each time we enter stuser_set_state(). Declare it as static.

See the link below for the discussion.

https://lore.kernel.org/r/20211014141859.11444-1-kelvin.cao@microchip.com/

[bhelgaas: simplify commit log]
Suggested-by: Krzysztof Wilczyński <kw@linux.com>
Link: https://lore.kernel.org/r/20211119003803.2333-3-kelvin.cao@microchip.com
Signed-off-by: Kelvin Cao <kelvin.cao@microchip.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Reviewed-by: Logan Gunthorpe <logang@deltatee.com>

authored by

Kelvin Cao and committed by
Bjorn Helgaas
b76521f6 bb17b158

+1 -1
+1 -1
drivers/pci/switch/switchtec.c
··· 122 122 { 123 123 /* requires the mrpc_mutex to already be held when called */ 124 124 125 - const char * const state_names[] = { 125 + static const char * const state_names[] = { 126 126 [MRPC_IDLE] = "IDLE", 127 127 [MRPC_QUEUED] = "QUEUED", 128 128 [MRPC_RUNNING] = "RUNNING",