Merge branch 'timers-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip

Pull timer fixes from Thomas Gleixner:
"A set of small fixes:

- regression fix for exynos_mct clocksource

- trivial build fix for kona clocksource

- functional one liner fix for the sh_tmu clocksource

- two validation fixes to prevent (root only) data corruption in the
kernel via settimeofday and adjtimex. Tagged for stable"

* 'timers-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip:
time: adjtimex: Validate the ADJ_FREQUENCY values
time: settimeofday: Validate the values of tv from user
clocksource: sh_tmu: Set cpu_possible_mask to fix SMP broadcast
clocksource: kona: fix __iomem annotation
clocksource: exynos_mct: Fix bitmask regression for exynos4_mct_write

Changed files
+31 -8
drivers
include
linux
kernel
time
+4 -5
drivers/clocksource/bcm_kona_timer.c
··· 68 68 } 69 69 70 70 static void 71 - kona_timer_get_counter(void *timer_base, uint32_t *msw, uint32_t *lsw) 71 + kona_timer_get_counter(void __iomem *timer_base, uint32_t *msw, uint32_t *lsw) 72 72 { 73 - void __iomem *base = IOMEM(timer_base); 74 73 int loop_limit = 4; 75 74 76 75 /* ··· 85 86 */ 86 87 87 88 while (--loop_limit) { 88 - *msw = readl(base + KONA_GPTIMER_STCHI_OFFSET); 89 - *lsw = readl(base + KONA_GPTIMER_STCLO_OFFSET); 90 - if (*msw == readl(base + KONA_GPTIMER_STCHI_OFFSET)) 89 + *msw = readl(timer_base + KONA_GPTIMER_STCHI_OFFSET); 90 + *lsw = readl(timer_base + KONA_GPTIMER_STCLO_OFFSET); 91 + if (*msw == readl(timer_base + KONA_GPTIMER_STCHI_OFFSET)) 91 92 break; 92 93 } 93 94 if (!loop_limit) {
+2 -2
drivers/clocksource/exynos_mct.c
··· 97 97 writel_relaxed(value, reg_base + offset); 98 98 99 99 if (likely(offset >= EXYNOS4_MCT_L_BASE(0))) { 100 - stat_addr = (offset & ~EXYNOS4_MCT_L_MASK) + MCT_L_WSTAT_OFFSET; 101 - switch (offset & EXYNOS4_MCT_L_MASK) { 100 + stat_addr = (offset & EXYNOS4_MCT_L_MASK) + MCT_L_WSTAT_OFFSET; 101 + switch (offset & ~EXYNOS4_MCT_L_MASK) { 102 102 case MCT_L_TCON_OFFSET: 103 103 mask = 1 << 3; /* L_TCON write status */ 104 104 break;
+1 -1
drivers/clocksource/sh_tmu.c
··· 428 428 ced->features = CLOCK_EVT_FEAT_PERIODIC; 429 429 ced->features |= CLOCK_EVT_FEAT_ONESHOT; 430 430 ced->rating = 200; 431 - ced->cpumask = cpumask_of(0); 431 + ced->cpumask = cpu_possible_mask; 432 432 ced->set_next_event = sh_tmu_clock_event_next; 433 433 ced->set_mode = sh_tmu_clock_event_mode; 434 434 ced->suspend = sh_tmu_clock_event_suspend;
+13
include/linux/time.h
··· 110 110 return true; 111 111 } 112 112 113 + static inline bool timeval_valid(const struct timeval *tv) 114 + { 115 + /* Dates before 1970 are bogus */ 116 + if (tv->tv_sec < 0) 117 + return false; 118 + 119 + /* Can't have more microseconds then a second */ 120 + if (tv->tv_usec < 0 || tv->tv_usec >= USEC_PER_SEC) 121 + return false; 122 + 123 + return true; 124 + } 125 + 113 126 extern struct timespec timespec_trunc(struct timespec t, unsigned gran); 114 127 115 128 #define CURRENT_TIME (current_kernel_time())
+7
kernel/time/ntp.c
··· 633 633 if ((txc->modes & ADJ_SETOFFSET) && (!capable(CAP_SYS_TIME))) 634 634 return -EPERM; 635 635 636 + if (txc->modes & ADJ_FREQUENCY) { 637 + if (LONG_MIN / PPM_SCALE > txc->freq) 638 + return -EINVAL; 639 + if (LONG_MAX / PPM_SCALE < txc->freq) 640 + return -EINVAL; 641 + } 642 + 636 643 return 0; 637 644 } 638 645
+4
kernel/time/time.c
··· 196 196 if (tv) { 197 197 if (copy_from_user(&user_tv, tv, sizeof(*tv))) 198 198 return -EFAULT; 199 + 200 + if (!timeval_valid(&user_tv)) 201 + return -EINVAL; 202 + 199 203 new_ts.tv_sec = user_tv.tv_sec; 200 204 new_ts.tv_nsec = user_tv.tv_usec * NSEC_PER_USEC; 201 205 }