Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

vlan: Rename VLAN_GROUP_ARRAY_LEN to VLAN_N_VID.

VLAN_GROUP_ARRAY_LEN is simply the number of possible vlan VIDs.
Since vlan groups will soon be more of an implementation detail
for vlan devices, rename the constant to be descriptive of its
actual purpose.

Signed-off-by: Jesse Gross <jesse@nicira.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

authored by

Jesse Gross and committed by
David S. Miller
b738127d 13937911

+27 -27
+1 -1
drivers/net/benet/be.h
··· 263 263 struct vlan_group *vlan_grp; 264 264 u16 vlans_added; 265 265 u16 max_vlans; /* Number of vlans supported */ 266 - u8 vlan_tag[VLAN_GROUP_ARRAY_LEN]; 266 + u8 vlan_tag[VLAN_N_VID]; 267 267 struct be_dma_mem mc_cmd_mem; 268 268 269 269 struct be_dma_mem stats_cmd;
+1 -1
drivers/net/benet/be_main.c
··· 626 626 627 627 if (adapter->vlans_added <= adapter->max_vlans) { 628 628 /* Construct VLAN Table to give to HW */ 629 - for (i = 0; i < VLAN_GROUP_ARRAY_LEN; i++) { 629 + for (i = 0; i < VLAN_N_VID; i++) { 630 630 if (adapter->vlan_tag[i]) { 631 631 vtag[ntags] = cpu_to_le16(i); 632 632 ntags++;
+1 -1
drivers/net/e1000/e1000_main.c
··· 4541 4541 4542 4542 if (adapter->vlgrp) { 4543 4543 u16 vid; 4544 - for (vid = 0; vid < VLAN_GROUP_ARRAY_LEN; vid++) { 4544 + for (vid = 0; vid < VLAN_N_VID; vid++) { 4545 4545 if (!vlan_group_get_device(adapter->vlgrp, vid)) 4546 4546 continue; 4547 4547 e1000_vlan_rx_add_vid(adapter->netdev, vid);
+1 -1
drivers/net/e1000e/netdev.c
··· 2545 2545 if (!adapter->vlgrp) 2546 2546 return; 2547 2547 2548 - for (vid = 0; vid < VLAN_GROUP_ARRAY_LEN; vid++) { 2548 + for (vid = 0; vid < VLAN_N_VID; vid++) { 2549 2549 if (!vlan_group_get_device(adapter->vlgrp, vid)) 2550 2550 continue; 2551 2551 e1000_vlan_rx_add_vid(adapter->netdev, vid);
+1 -1
drivers/net/igb/igb_main.c
··· 6153 6153 6154 6154 if (adapter->vlgrp) { 6155 6155 u16 vid; 6156 - for (vid = 0; vid < VLAN_GROUP_ARRAY_LEN; vid++) { 6156 + for (vid = 0; vid < VLAN_N_VID; vid++) { 6157 6157 if (!vlan_group_get_device(adapter->vlgrp, vid)) 6158 6158 continue; 6159 6159 igb_vlan_rx_add_vid(adapter->netdev, vid);
+1 -1
drivers/net/igbvf/netdev.c
··· 1254 1254 if (!adapter->vlgrp) 1255 1255 return; 1256 1256 1257 - for (vid = 0; vid < VLAN_GROUP_ARRAY_LEN; vid++) { 1257 + for (vid = 0; vid < VLAN_N_VID; vid++) { 1258 1258 if (!vlan_group_get_device(adapter->vlgrp, vid)) 1259 1259 continue; 1260 1260 igbvf_vlan_rx_add_vid(adapter->netdev, vid);
+1 -1
drivers/net/ixgb/ixgb_main.c
··· 2223 2223 2224 2224 if (adapter->vlgrp) { 2225 2225 u16 vid; 2226 - for (vid = 0; vid < VLAN_GROUP_ARRAY_LEN; vid++) { 2226 + for (vid = 0; vid < VLAN_N_VID; vid++) { 2227 2227 if (!vlan_group_get_device(adapter->vlgrp, vid)) 2228 2228 continue; 2229 2229 ixgb_vlan_rx_add_vid(adapter->netdev, vid);
+1 -1
drivers/net/ixgbe/ixgbe_main.c
··· 3185 3185 3186 3186 if (adapter->vlgrp) { 3187 3187 u16 vid; 3188 - for (vid = 0; vid < VLAN_GROUP_ARRAY_LEN; vid++) { 3188 + for (vid = 0; vid < VLAN_N_VID; vid++) { 3189 3189 if (!vlan_group_get_device(adapter->vlgrp, vid)) 3190 3190 continue; 3191 3191 ixgbe_vlan_rx_add_vid(adapter->netdev, vid);
+1 -1
drivers/net/ixgbevf/ixgbevf_main.c
··· 1495 1495 1496 1496 if (adapter->vlgrp) { 1497 1497 u16 vid; 1498 - for (vid = 0; vid < VLAN_GROUP_ARRAY_LEN; vid++) { 1498 + for (vid = 0; vid < VLAN_N_VID; vid++) { 1499 1499 if (!vlan_group_get_device(adapter->vlgrp, vid)) 1500 1500 continue; 1501 1501 ixgbevf_vlan_rx_add_vid(adapter->netdev, vid);
+1 -1
drivers/net/qlcnic/qlcnic_main.c
··· 4093 4093 if (!adapter->vlgrp) 4094 4094 return; 4095 4095 4096 - for (vid = 0; vid < VLAN_GROUP_ARRAY_LEN; vid++) { 4096 + for (vid = 0; vid < VLAN_N_VID; vid++) { 4097 4097 dev = vlan_group_get_device(adapter->vlgrp, vid); 4098 4098 if (!dev) 4099 4099 continue;
+1 -1
drivers/net/vmxnet3/vmxnet3_drv.c
··· 1634 1634 u32 *vfTable = adapter->shared->devRead.rxFilterConf.vfTable; 1635 1635 bool activeVlan = false; 1636 1636 1637 - for (vid = 0; vid < VLAN_GROUP_ARRAY_LEN; vid++) { 1637 + for (vid = 0; vid < VLAN_N_VID; vid++) { 1638 1638 if (vlan_group_get_device(adapter->vlan_grp, vid)) { 1639 1639 VMXNET3_SET_VFTABLE_ENTRY(vfTable, vid); 1640 1640 activeVlan = true;
+1 -1
drivers/net/vxge/vxge-main.c
··· 1862 1862 1863 1863 if (vdev->vlgrp && vpath->is_open) { 1864 1864 1865 - for (vid = 0; vid < VLAN_GROUP_ARRAY_LEN; vid++) { 1865 + for (vid = 0; vid < VLAN_N_VID; vid++) { 1866 1866 if (!vlan_group_get_device(vdev->vlgrp, vid)) 1867 1867 continue; 1868 1868 /* Add these vlan to the vid table */
+3 -3
drivers/s390/net/qeth_l3_main.c
··· 1820 1820 return; 1821 1821 1822 1822 vg = card->vlangrp; 1823 - for (i = 0; i < VLAN_GROUP_ARRAY_LEN; i++) { 1823 + for (i = 0; i < VLAN_N_VID; i++) { 1824 1824 struct net_device *netdev = vlan_group_get_device(vg, i); 1825 1825 if (netdev == NULL || 1826 1826 !(netdev->flags & IFF_UP)) ··· 1883 1883 return; 1884 1884 1885 1885 vg = card->vlangrp; 1886 - for (i = 0; i < VLAN_GROUP_ARRAY_LEN; i++) { 1886 + for (i = 0; i < VLAN_N_VID; i++) { 1887 1887 struct net_device *netdev = vlan_group_get_device(vg, i); 1888 1888 if (netdev == NULL || 1889 1889 !(netdev->flags & IFF_UP)) ··· 2247 2247 if (!vg) 2248 2248 return rc; 2249 2249 2250 - for (i = 0; i < VLAN_GROUP_ARRAY_LEN; i++) { 2250 + for (i = 0; i < VLAN_N_VID; i++) { 2251 2251 if (vlan_group_get_device(vg, i) == dev) { 2252 2252 rc = QETH_VLAN_CARD; 2253 2253 break;
+2 -2
include/linux/if_vlan.h
··· 68 68 #define VLAN_CFI_MASK 0x1000 /* Canonical Format Indicator */ 69 69 #define VLAN_TAG_PRESENT VLAN_CFI_MASK 70 70 #define VLAN_VID_MASK 0x0fff /* VLAN Identifier */ 71 + #define VLAN_N_VID 4096 71 72 72 73 /* found in socket.c */ 73 74 extern void vlan_ioctl_set(int (*hook)(struct net *, void __user *)); ··· 77 76 * depends on completely exhausting the VLAN identifier space. Thus 78 77 * it gives constant time look-up, but in many cases it wastes memory. 79 78 */ 80 - #define VLAN_GROUP_ARRAY_LEN 4096 81 79 #define VLAN_GROUP_ARRAY_SPLIT_PARTS 8 82 - #define VLAN_GROUP_ARRAY_PART_LEN (VLAN_GROUP_ARRAY_LEN/VLAN_GROUP_ARRAY_SPLIT_PARTS) 80 + #define VLAN_GROUP_ARRAY_PART_LEN (VLAN_N_VID/VLAN_GROUP_ARRAY_SPLIT_PARTS) 83 81 84 82 struct vlan_group { 85 83 struct net_device *real_dev; /* The ethernet(like) device
+8 -8
net/8021q/vlan.c
··· 439 439 switch (event) { 440 440 case NETDEV_CHANGE: 441 441 /* Propagate real device state to vlan devices */ 442 - for (i = 0; i < VLAN_GROUP_ARRAY_LEN; i++) { 442 + for (i = 0; i < VLAN_N_VID; i++) { 443 443 vlandev = vlan_group_get_device(grp, i); 444 444 if (!vlandev) 445 445 continue; ··· 450 450 451 451 case NETDEV_CHANGEADDR: 452 452 /* Adjust unicast filters on underlying device */ 453 - for (i = 0; i < VLAN_GROUP_ARRAY_LEN; i++) { 453 + for (i = 0; i < VLAN_N_VID; i++) { 454 454 vlandev = vlan_group_get_device(grp, i); 455 455 if (!vlandev) 456 456 continue; ··· 464 464 break; 465 465 466 466 case NETDEV_CHANGEMTU: 467 - for (i = 0; i < VLAN_GROUP_ARRAY_LEN; i++) { 467 + for (i = 0; i < VLAN_N_VID; i++) { 468 468 vlandev = vlan_group_get_device(grp, i); 469 469 if (!vlandev) 470 470 continue; ··· 478 478 479 479 case NETDEV_FEAT_CHANGE: 480 480 /* Propagate device features to underlying device */ 481 - for (i = 0; i < VLAN_GROUP_ARRAY_LEN; i++) { 481 + for (i = 0; i < VLAN_N_VID; i++) { 482 482 vlandev = vlan_group_get_device(grp, i); 483 483 if (!vlandev) 484 484 continue; ··· 490 490 491 491 case NETDEV_DOWN: 492 492 /* Put all VLANs for this dev in the down state too. */ 493 - for (i = 0; i < VLAN_GROUP_ARRAY_LEN; i++) { 493 + for (i = 0; i < VLAN_N_VID; i++) { 494 494 vlandev = vlan_group_get_device(grp, i); 495 495 if (!vlandev) 496 496 continue; ··· 508 508 509 509 case NETDEV_UP: 510 510 /* Put all VLANs for this dev in the up state too. */ 511 - for (i = 0; i < VLAN_GROUP_ARRAY_LEN; i++) { 511 + for (i = 0; i < VLAN_N_VID; i++) { 512 512 vlandev = vlan_group_get_device(grp, i); 513 513 if (!vlandev) 514 514 continue; ··· 532 532 /* Delete all VLANs for this dev. */ 533 533 grp->killall = 1; 534 534 535 - for (i = 0; i < VLAN_GROUP_ARRAY_LEN; i++) { 535 + for (i = 0; i < VLAN_N_VID; i++) { 536 536 vlandev = vlan_group_get_device(grp, i); 537 537 if (!vlandev) 538 538 continue; ··· 540 540 /* unregistration of last vlan destroys group, abort 541 541 * afterwards */ 542 542 if (grp->nr_vlans == 1) 543 - i = VLAN_GROUP_ARRAY_LEN; 543 + i = VLAN_N_VID; 544 544 545 545 unregister_vlan_dev(vlandev, &list); 546 546 }
+2 -2
net/bridge/netfilter/ebt_vlan.c
··· 118 118 * 0 - The null VLAN ID. 119 119 * 1 - The default Port VID (PVID) 120 120 * 0x0FFF - Reserved for implementation use. 121 - * if_vlan.h: VLAN_GROUP_ARRAY_LEN 4096. */ 121 + * if_vlan.h: VLAN_N_VID 4096. */ 122 122 if (GET_BITMASK(EBT_VLAN_ID)) { 123 123 if (!!info->id) { /* if id!=0 => check vid range */ 124 - if (info->id > VLAN_GROUP_ARRAY_LEN) { 124 + if (info->id > VLAN_N_VID) { 125 125 pr_debug("id %d is out of range (1-4096)\n", 126 126 info->id); 127 127 return -EINVAL;