Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

eth: switch to netif_napi_add_weight()

Switch all Ethernet drivers which use custom napi weights
to the new API.

Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>

authored by

Jakub Kicinski and committed by
David S. Miller
b707b89f be8af67f

+58 -47
+1 -1
drivers/net/ethernet/3com/typhoon.c
··· 2464 2464 2465 2465 /* The chip-specific entries in the device structure. */ 2466 2466 dev->netdev_ops = &typhoon_netdev_ops; 2467 - netif_napi_add(dev, &tp->napi, typhoon_poll, 16); 2467 + netif_napi_add_weight(dev, &tp->napi, typhoon_poll, 16); 2468 2468 dev->watchdog_timeo = TX_TIMEOUT; 2469 2469 2470 2470 dev->ethtool_ops = &typhoon_ethtool_ops;
+1 -1
drivers/net/ethernet/adaptec/starfire.c
··· 772 772 dev->watchdog_timeo = TX_TIMEOUT; 773 773 dev->ethtool_ops = &ethtool_ops; 774 774 775 - netif_napi_add(dev, &np->napi, netdev_poll, max_interrupt_work); 775 + netif_napi_add_weight(dev, &np->napi, netdev_poll, max_interrupt_work); 776 776 777 777 if (mtu) 778 778 dev->mtu = mtu;
+1 -1
drivers/net/ethernet/amd/amd8111e.c
··· 1828 1828 dev->watchdog_timeo = AMD8111E_TX_TIMEOUT; 1829 1829 dev->min_mtu = AMD8111E_MIN_MTU; 1830 1830 dev->max_mtu = AMD8111E_MAX_MTU; 1831 - netif_napi_add(dev, &lp->napi, amd8111e_rx_poll, 32); 1831 + netif_napi_add_weight(dev, &lp->napi, amd8111e_rx_poll, 32); 1832 1832 1833 1833 #if AMD8111E_VLAN_TAG_USED 1834 1834 dev->features |= NETIF_F_HW_VLAN_CTAG_TX | NETIF_F_HW_VLAN_CTAG_RX;
+2 -1
drivers/net/ethernet/amd/pcnet32.c
··· 1881 1881 /* napi.weight is used in both the napi and non-napi cases */ 1882 1882 lp->napi.weight = lp->rx_ring_size / 2; 1883 1883 1884 - netif_napi_add(dev, &lp->napi, pcnet32_poll, lp->rx_ring_size / 2); 1884 + netif_napi_add_weight(dev, &lp->napi, pcnet32_poll, 1885 + lp->rx_ring_size / 2); 1885 1886 1886 1887 if (fdx && !(lp->options & PCNET32_PORT_ASEL) && 1887 1888 ((cards_found >= MAX_UNITS) || full_duplex[cards_found]))
+2 -1
drivers/net/ethernet/arc/emac_main.c
··· 981 981 dev_info(dev, "connected to %s phy with id 0x%x\n", 982 982 phydev->drv->name, phydev->phy_id); 983 983 984 - netif_napi_add(ndev, &priv->napi, arc_emac_poll, ARC_EMAC_NAPI_WEIGHT); 984 + netif_napi_add_weight(ndev, &priv->napi, arc_emac_poll, 985 + ARC_EMAC_NAPI_WEIGHT); 985 986 986 987 err = register_netdev(ndev); 987 988 if (err) {
+2 -1
drivers/net/ethernet/atheros/ag71xx.c
··· 1922 1922 return err; 1923 1923 } 1924 1924 1925 - netif_napi_add(ndev, &ag->napi, ag71xx_poll, AG71XX_NAPI_WEIGHT); 1925 + netif_napi_add_weight(ndev, &ag->napi, ag71xx_poll, 1926 + AG71XX_NAPI_WEIGHT); 1926 1927 1927 1928 err = clk_prepare_enable(ag->clk_eth); 1928 1929 if (err) {
+2 -2
drivers/net/ethernet/broadcom/bcm63xx_enet.c
··· 1859 1859 1860 1860 /* register netdevice */ 1861 1861 dev->netdev_ops = &bcm_enet_ops; 1862 - netif_napi_add(dev, &priv->napi, bcm_enet_poll, 16); 1862 + netif_napi_add_weight(dev, &priv->napi, bcm_enet_poll, 16); 1863 1863 1864 1864 dev->ethtool_ops = &bcm_enet_ethtool_ops; 1865 1865 /* MTU range: 46 - 2028 */ ··· 2714 2714 2715 2715 /* register netdevice */ 2716 2716 dev->netdev_ops = &bcm_enetsw_ops; 2717 - netif_napi_add(dev, &priv->napi, bcm_enet_poll, 16); 2717 + netif_napi_add_weight(dev, &priv->napi, bcm_enet_poll, 16); 2718 2718 dev->ethtool_ops = &bcm_enetsw_ethtool_ops; 2719 2719 SET_NETDEV_DEV(dev, &pdev->dev); 2720 2720
+1 -1
drivers/net/ethernet/broadcom/sb1250-mac.c
··· 2203 2203 dev->min_mtu = 0; 2204 2204 dev->max_mtu = ENET_PACKET_SIZE; 2205 2205 2206 - netif_napi_add(dev, &sc->napi, sbmac_poll, 16); 2206 + netif_napi_add_weight(dev, &sc->napi, sbmac_poll, 16); 2207 2207 2208 2208 dev->irq = UNIT_INT(idx); 2209 2209
+1 -1
drivers/net/ethernet/dec/tulip/tulip_core.c
··· 1689 1689 dev->netdev_ops = &tulip_netdev_ops; 1690 1690 dev->watchdog_timeo = TX_TIMEOUT; 1691 1691 #ifdef CONFIG_TULIP_NAPI 1692 - netif_napi_add(dev, &tp->napi, tulip_poll, 16); 1692 + netif_napi_add_weight(dev, &tp->napi, tulip_poll, 16); 1693 1693 #endif 1694 1694 dev->ethtool_ops = &ops; 1695 1695
+2 -2
drivers/net/ethernet/ezchip/nps_enet.c
··· 612 612 goto out_netdev; 613 613 } 614 614 615 - netif_napi_add(ndev, &priv->napi, nps_enet_poll, 616 - NPS_ENET_NAPI_POLL_WEIGHT); 615 + netif_napi_add_weight(ndev, &priv->napi, nps_enet_poll, 616 + NPS_ENET_NAPI_POLL_WEIGHT); 617 617 618 618 /* Register the driver. Should be the last thing in probe */ 619 619 err = register_netdev(ndev);
+2 -1
drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c
··· 1020 1020 ndev->netdev_ops = &fs_enet_netdev_ops; 1021 1021 ndev->watchdog_timeo = 2 * HZ; 1022 1022 INIT_WORK(&fep->timeout_work, fs_timeout_work); 1023 - netif_napi_add(ndev, &fep->napi, fs_enet_napi, fpi->napi_weight); 1023 + netif_napi_add_weight(ndev, &fep->napi, fs_enet_napi, 1024 + fpi->napi_weight); 1024 1025 1025 1026 ndev->ethtool_ops = &fs_ethtool_ops; 1026 1027
+2 -1
drivers/net/ethernet/hisilicon/hisi_femac.c
··· 852 852 ndev->priv_flags |= IFF_UNICAST_FLT; 853 853 ndev->netdev_ops = &hisi_femac_netdev_ops; 854 854 ndev->ethtool_ops = &hisi_femac_ethtools_ops; 855 - netif_napi_add(ndev, &priv->napi, hisi_femac_poll, FEMAC_POLL_WEIGHT); 855 + netif_napi_add_weight(ndev, &priv->napi, hisi_femac_poll, 856 + FEMAC_POLL_WEIGHT); 856 857 857 858 hisi_femac_port_init(priv); 858 859
+2 -1
drivers/net/ethernet/huawei/hinic/hinic_rx.c
··· 481 481 { 482 482 struct hinic_dev *nic_dev = netdev_priv(rxq->netdev); 483 483 484 - netif_napi_add(rxq->netdev, &rxq->napi, rx_poll, nic_dev->rx_weight); 484 + netif_napi_add_weight(rxq->netdev, &rxq->napi, rx_poll, 485 + nic_dev->rx_weight); 485 486 napi_enable(&rxq->napi); 486 487 } 487 488
+2 -1
drivers/net/ethernet/huawei/hinic/hinic_tx.c
··· 809 809 810 810 qp = container_of(sq, struct hinic_qp, sq); 811 811 812 - netif_napi_add(txq->netdev, &txq->napi, free_tx_poll, nic_dev->tx_weight); 812 + netif_napi_add_weight(txq->netdev, &txq->napi, free_tx_poll, 813 + nic_dev->tx_weight); 813 814 814 815 hinic_hwdev_msix_set(nic_dev->hwdev, sq->msix_entry, 815 816 TX_IRQ_NO_PENDING, TX_IRQ_NO_COALESC,
+2 -2
drivers/net/ethernet/ibm/emac/mal.c
··· 605 605 606 606 init_dummy_netdev(&mal->dummy_dev); 607 607 608 - netif_napi_add(&mal->dummy_dev, &mal->napi, mal_poll, 609 - CONFIG_IBM_EMAC_POLL_WEIGHT); 608 + netif_napi_add_weight(&mal->dummy_dev, &mal->napi, mal_poll, 609 + CONFIG_IBM_EMAC_POLL_WEIGHT); 610 610 611 611 /* Load power-on reset defaults */ 612 612 mal_reset(mal);
+1 -1
drivers/net/ethernet/ibm/ibmveth.c
··· 1674 1674 adapter->pool_config = 0; 1675 1675 ibmveth_init_link_settings(netdev); 1676 1676 1677 - netif_napi_add(netdev, &adapter->napi, ibmveth_poll, 16); 1677 + netif_napi_add_weight(netdev, &adapter->napi, ibmveth_poll, 16); 1678 1678 1679 1679 netdev->irq = dev->irq; 1680 1680 netdev->netdev_ops = &ibmveth_netdev_ops;
+1 -1
drivers/net/ethernet/intel/e100.c
··· 2848 2848 strncpy(netdev->name, pci_name(pdev), sizeof(netdev->name) - 1); 2849 2849 2850 2850 nic = netdev_priv(netdev); 2851 - netif_napi_add(netdev, &nic->napi, e100_poll, E100_NAPI_WEIGHT); 2851 + netif_napi_add_weight(netdev, &nic->napi, e100_poll, E100_NAPI_WEIGHT); 2852 2852 nic->netdev = netdev; 2853 2853 nic->pdev = pdev; 2854 2854 nic->msg_enable = (1 << debug) - 1;
+4 -4
drivers/net/ethernet/lantiq_etop.c
··· 701 701 702 702 for (i = 0; i < MAX_DMA_CHAN; i++) { 703 703 if (IS_TX(i)) 704 - netif_napi_add(dev, &priv->ch[i].napi, 705 - ltq_etop_poll_tx, 8); 704 + netif_napi_add_weight(dev, &priv->ch[i].napi, 705 + ltq_etop_poll_tx, 8); 706 706 else if (IS_RX(i)) 707 - netif_napi_add(dev, &priv->ch[i].napi, 708 - ltq_etop_poll_rx, 32); 707 + netif_napi_add_weight(dev, &priv->ch[i].napi, 708 + ltq_etop_poll_rx, 32); 709 709 priv->ch[i].netdev = dev; 710 710 } 711 711
+2 -1
drivers/net/ethernet/marvell/pxa168_eth.c
··· 1486 1486 1487 1487 /* Hardware supports only 3 ports */ 1488 1488 BUG_ON(pep->port_num > 2); 1489 - netif_napi_add(dev, &pep->napi, pxa168_rx_poll, pep->rx_ring_size); 1489 + netif_napi_add_weight(dev, &pep->napi, pxa168_rx_poll, 1490 + pep->rx_ring_size); 1490 1491 1491 1492 memset(&pep->timeout, 0, sizeof(struct timer_list)); 1492 1493 timer_setup(&pep->timeout, rxq_refill_timer_wrapper, 0);
+2 -1
drivers/net/ethernet/microchip/sparx5/sparx5_fdma.c
··· 381 381 } 382 382 sparx5_fdma_rx_add_dcb(rx, dcb, rx->dma + sizeof(*dcb) * idx); 383 383 } 384 - netif_napi_add(rx->ndev, &rx->napi, sparx5_fdma_napi_callback, FDMA_WEIGHT); 384 + netif_napi_add_weight(rx->ndev, &rx->napi, sparx5_fdma_napi_callback, 385 + FDMA_WEIGHT); 385 386 napi_enable(&rx->napi); 386 387 sparx5_fdma_rx_activate(sparx5, rx); 387 388 return 0;
+1 -1
drivers/net/ethernet/microsoft/mana/mana_en.c
··· 1602 1602 1603 1603 gc->cq_table[cq->gdma_id] = cq->gdma_cq; 1604 1604 1605 - netif_napi_add(ndev, &cq->napi, mana_poll, 1); 1605 + netif_napi_add_weight(ndev, &cq->napi, mana_poll, 1); 1606 1606 1607 1607 WARN_ON(xdp_rxq_info_reg(&rxq->xdp_rxq, ndev, rxq_idx, 1608 1608 cq->napi.napi_id));
+1 -1
drivers/net/ethernet/moxa/moxart_ether.c
··· 533 533 } 534 534 535 535 ndev->netdev_ops = &moxart_netdev_ops; 536 - netif_napi_add(ndev, &priv->napi, moxart_rx_poll, RX_DESC_NUM); 536 + netif_napi_add_weight(ndev, &priv->napi, moxart_rx_poll, RX_DESC_NUM); 537 537 ndev->priv_flags |= IFF_UNICAST_FLT; 538 538 ndev->irq = irq; 539 539
+2 -2
drivers/net/ethernet/mscc/ocelot_fdma.c
··· 799 799 return; 800 800 801 801 fdma->ndev = dev; 802 - netif_napi_add(dev, &fdma->napi, ocelot_fdma_napi_poll, 803 - OCELOT_FDMA_WEIGHT); 802 + netif_napi_add_weight(dev, &fdma->napi, ocelot_fdma_napi_poll, 803 + OCELOT_FDMA_WEIGHT); 804 804 } 805 805 806 806 void ocelot_fdma_netdev_deinit(struct ocelot *ocelot, struct net_device *dev)
+2 -2
drivers/net/ethernet/myricom/myri10ge/myri10ge.c
··· 3586 3586 goto abort; 3587 3587 ss->mgp = mgp; 3588 3588 ss->dev = mgp->dev; 3589 - netif_napi_add(ss->dev, &ss->napi, myri10ge_poll, 3590 - myri10ge_napi_weight); 3589 + netif_napi_add_weight(ss->dev, &ss->napi, myri10ge_poll, 3590 + myri10ge_napi_weight); 3591 3591 } 3592 3592 return 0; 3593 3593 abort:
+5 -4
drivers/net/ethernet/neterion/vxge/vxge-main.c
··· 2720 2720 } 2721 2721 2722 2722 if (vdev->config.intr_type != MSI_X) { 2723 - netif_napi_add(dev, &vdev->napi, vxge_poll_inta, 2724 - vdev->config.napi_weight); 2723 + netif_napi_add_weight(dev, &vdev->napi, vxge_poll_inta, 2724 + vdev->config.napi_weight); 2725 2725 napi_enable(&vdev->napi); 2726 2726 for (i = 0; i < vdev->no_of_vpath; i++) { 2727 2727 vpath = &vdev->vpaths[i]; ··· 2730 2730 } else { 2731 2731 for (i = 0; i < vdev->no_of_vpath; i++) { 2732 2732 vpath = &vdev->vpaths[i]; 2733 - netif_napi_add(dev, &vpath->ring.napi, 2734 - vxge_poll_msix, vdev->config.napi_weight); 2733 + netif_napi_add_weight(dev, &vpath->ring.napi, 2734 + vxge_poll_msix, 2735 + vdev->config.napi_weight); 2735 2736 napi_enable(&vpath->ring.napi); 2736 2737 vpath->ring.napi_p = &vpath->ring.napi; 2737 2738 }
+1 -1
drivers/net/ethernet/nxp/lpc_eth.c
··· 1373 1373 pldat->duplex = DUPLEX_FULL; 1374 1374 __lpc_params_setup(pldat); 1375 1375 1376 - netif_napi_add(ndev, &pldat->napi, lpc_eth_poll, NAPI_WEIGHT); 1376 + netif_napi_add_weight(ndev, &pldat->napi, lpc_eth_poll, NAPI_WEIGHT); 1377 1377 1378 1378 ret = register_netdev(ndev); 1379 1379 if (ret) {
+1 -1
drivers/net/ethernet/realtek/8139cp.c
··· 1986 1986 eth_hw_addr_set(dev, (u8 *)addr); 1987 1987 1988 1988 dev->netdev_ops = &cp_netdev_ops; 1989 - netif_napi_add(dev, &cp->napi, cp_rx_poll, 16); 1989 + netif_napi_add_weight(dev, &cp->napi, cp_rx_poll, 16); 1990 1990 dev->ethtool_ops = &cp_ethtool_ops; 1991 1991 dev->watchdog_timeo = TX_TIMEOUT; 1992 1992
+2 -2
drivers/net/ethernet/sfc/efx_channels.c
··· 1316 1316 struct efx_nic *efx = channel->efx; 1317 1317 1318 1318 channel->napi_dev = efx->net_dev; 1319 - netif_napi_add(channel->napi_dev, &channel->napi_str, 1320 - efx_poll, napi_weight); 1319 + netif_napi_add_weight(channel->napi_dev, &channel->napi_str, efx_poll, 1320 + napi_weight); 1321 1321 } 1322 1322 1323 1323 void efx_init_napi(struct efx_nic *efx)
+2 -2
drivers/net/ethernet/sfc/falcon/efx.c
··· 2017 2017 struct ef4_nic *efx = channel->efx; 2018 2018 2019 2019 channel->napi_dev = efx->net_dev; 2020 - netif_napi_add(channel->napi_dev, &channel->napi_str, 2021 - ef4_poll, napi_weight); 2020 + netif_napi_add_weight(channel->napi_dev, &channel->napi_str, ef4_poll, 2021 + napi_weight); 2022 2022 } 2023 2023 2024 2024 static void ef4_init_napi(struct ef4_nic *efx)
+2 -1
drivers/net/ethernet/smsc/smsc911x.c
··· 2304 2304 return -ENODEV; 2305 2305 2306 2306 dev->flags |= IFF_MULTICAST; 2307 - netif_napi_add(dev, &pdata->napi, smsc911x_poll, SMSC_NAPI_WEIGHT); 2307 + netif_napi_add_weight(dev, &pdata->napi, smsc911x_poll, 2308 + SMSC_NAPI_WEIGHT); 2308 2309 dev->netdev_ops = &smsc911x_netdev_ops; 2309 2310 dev->ethtool_ops = &smsc911x_ethtool_ops; 2310 2311
+1 -1
drivers/net/ethernet/toshiba/tc35815.c
··· 804 804 dev->netdev_ops = &tc35815_netdev_ops; 805 805 dev->ethtool_ops = &tc35815_ethtool_ops; 806 806 dev->watchdog_timeo = TC35815_TX_TIMEOUT; 807 - netif_napi_add(dev, &lp->napi, tc35815_poll, NAPI_WEIGHT); 807 + netif_napi_add_weight(dev, &lp->napi, tc35815_poll, NAPI_WEIGHT); 808 808 809 809 dev->irq = pdev->irq; 810 810 dev->base_addr = (unsigned long)ioaddr;
+1 -1
drivers/net/ethernet/wiznet/w5100.c
··· 1133 1133 1134 1134 ndev->netdev_ops = &w5100_netdev_ops; 1135 1135 ndev->ethtool_ops = &w5100_ethtool_ops; 1136 - netif_napi_add(ndev, &priv->napi, w5100_napi_poll, 16); 1136 + netif_napi_add_weight(ndev, &priv->napi, w5100_napi_poll, 16); 1137 1137 1138 1138 /* This chip doesn't support VLAN packets with normal MTU, 1139 1139 * so disable VLAN for this device.
+1 -1
drivers/net/ethernet/wiznet/w5300.c
··· 603 603 ndev->netdev_ops = &w5300_netdev_ops; 604 604 ndev->ethtool_ops = &w5300_ethtool_ops; 605 605 ndev->watchdog_timeo = HZ; 606 - netif_napi_add(ndev, &priv->napi, w5300_napi_poll, 16); 606 + netif_napi_add_weight(ndev, &priv->napi, w5300_napi_poll, 16); 607 607 608 608 /* This chip doesn't support VLAN packets with normal MTU, 609 609 * so disable VLAN for this device.
+1 -1
drivers/net/ethernet/xscale/ixp4xx_eth.c
··· 1480 1480 ndev->dev.dma_mask = dev->dma_mask; 1481 1481 ndev->dev.coherent_dma_mask = dev->coherent_dma_mask; 1482 1482 1483 - netif_napi_add(ndev, &port->napi, eth_poll, NAPI_WEIGHT); 1483 + netif_napi_add_weight(ndev, &port->napi, eth_poll, NAPI_WEIGHT); 1484 1484 1485 1485 if (!(port->npe = npe_request(NPE_ID(port->id)))) 1486 1486 return -EIO;