Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

drm/panfrost: fix UAPI kernel-doc warnings

Fix all kernel-doc warnings in include/uapi/drm/panfrost_drm.h.
This mostly means modifying existing comments to conform to
kernel-doc format, but there also some additions of missing
kernel-doc comments and changing non-kernel-doc comments to
use "/*" to begin them.

Warning: panfrost_drm.h:83 struct member 'jc' not described
in 'drm_panfrost_submit'
Warning: panfrost_drm.h:83 struct member 'in_syncs' not described
in 'drm_panfrost_submit'
Warning: panfrost_drm.h:83 struct member 'in_sync_count' not described
in 'drm_panfrost_submit'
Warning: panfrost_drm.h:83 struct member 'out_sync' not described
in 'drm_panfrost_submit'
Warning: panfrost_drm.h:83 struct member 'bo_handles' not described
in 'drm_panfrost_submit'
Warning: panfrost_drm.h:83 struct member 'bo_handle_count' not described
in 'drm_panfrost_submit'
Warning: panfrost_drm.h:83 struct member 'requirements' not described
in 'drm_panfrost_submit'
Warning: panfrost_drm.h:83 struct member 'jm_ctx_handle' not described
in 'drm_panfrost_submit'
Warning: panfrost_drm.h:83 struct member 'pad' not described
in 'drm_panfrost_submit'
Warning: panfrost_drm.h:116 Incorrect use of kernel-doc format:
* Returned offset for the BO in the GPU address space. This offset
Warning: panfrost_drm.h:124 struct member 'size' not described
in 'drm_panfrost_create_bo'
Warning: panfrost_drm.h:124 struct member 'flags' not described
in 'drm_panfrost_create_bo'
Warning: panfrost_drm.h:124 struct member 'handle' not described
in 'drm_panfrost_create_bo'
Warning: panfrost_drm.h:124 struct member 'pad' not described
in 'drm_panfrost_create_bo'
Warning: panfrost_drm.h:124 struct member 'nonzero' not described
in 'drm_panfrost_create_bo'
Warning: panfrost_drm.h:143 struct member 'handle' not described
in 'drm_panfrost_mmap_bo'
Warning: panfrost_drm.h:143 struct member 'flags' not described
in 'drm_panfrost_mmap_bo'
Warning: panfrost_drm.h:143 struct member 'offset' not described
in 'drm_panfrost_mmap_bo'

Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Reviewed-by: Steven Price <steven.price@arm.com>
Reviewed-by: Adrián Larumbe <adrian.larumbe@collabora.com>
Signed-off-by: Steven Price <steven.price@arm.com>
Link: https://patch.msgid.link/20251031054152.1406764-1-rdunlap@infradead.org

authored by

Randy Dunlap and committed by
Steven Price
b6fa6100 3301ef0a

+82 -36
+82 -36
include/uapi/drm/panfrost_drm.h
··· 54 54 * This asks the kernel to have the GPU execute a render command list. 55 55 */ 56 56 struct drm_panfrost_submit { 57 - 58 - /** Address to GPU mapping of job descriptor */ 57 + /** 58 + * @jc: Address to GPU mapping of job descriptor 59 + */ 59 60 __u64 jc; 60 - 61 - /** An optional array of sync objects to wait on before starting this job. */ 61 + /** 62 + * @in_syncs: An optional array of sync objects to wait on 63 + * before starting this job. 64 + */ 62 65 __u64 in_syncs; 63 - 64 - /** Number of sync objects to wait on before starting this job. */ 66 + /** 67 + * @in_sync_count: Number of sync objects to wait on before 68 + * starting this job. 69 + */ 65 70 __u32 in_sync_count; 66 - 67 - /** An optional sync object to place the completion fence in. */ 71 + /** 72 + * @out_sync: An optional sync object to place the completion fence in. 73 + */ 68 74 __u32 out_sync; 69 - 70 - /** Pointer to a u32 array of the BOs that are referenced by the job. */ 75 + /** 76 + * @bo_handles: Pointer to a u32 array of the BOs that are 77 + * referenced by the job. 78 + */ 71 79 __u64 bo_handles; 72 - 73 - /** Number of BO handles passed in (size is that times 4). */ 80 + /** 81 + * @bo_handle_count: Number of BO handles passed in (size is 82 + * that times 4). 83 + */ 74 84 __u32 bo_handle_count; 75 - 76 - /** A combination of PANFROST_JD_REQ_* */ 85 + /** 86 + * @requirements: A combination of PANFROST_JD_REQ_* 87 + */ 77 88 __u32 requirements; 78 - 79 - /** JM context handle. Zero if you want to use the default context. */ 89 + /** 90 + * @jm_ctx_handle: JM context handle. Zero if you want to use the 91 + * default context. 92 + */ 80 93 __u32 jm_ctx_handle; 81 - 82 - /** Padding field. MBZ. */ 94 + /** 95 + * @pad: Padding field. Must be zero. 96 + */ 83 97 __u32 pad; 84 98 }; 85 99 ··· 106 92 * completed. 107 93 */ 108 94 struct drm_panfrost_wait_bo { 95 + /** 96 + * @handle: Handle for the object to wait for. 97 + */ 109 98 __u32 handle; 99 + /** 100 + * @pad: Padding, must be zero-filled. 101 + */ 110 102 __u32 pad; 111 - __s64 timeout_ns; /* absolute */ 103 + /** 104 + * @timeout_ns: absolute number of nanoseconds to wait. 105 + */ 106 + __s64 timeout_ns; 112 107 }; 113 108 114 109 /* Valid flags to pass to drm_panfrost_create_bo */ ··· 130 107 * The flags argument is a bit mask of PANFROST_BO_* flags. 131 108 */ 132 109 struct drm_panfrost_create_bo { 110 + /** 111 + * @size: size of shmem/BO area to create (bytes) 112 + */ 133 113 __u32 size; 114 + /** 115 + * @flags: see PANFROST_BO_* flags 116 + */ 134 117 __u32 flags; 135 - /** Returned GEM handle for the BO. */ 118 + /** 119 + * @handle: Returned GEM handle for the BO. 120 + */ 136 121 __u32 handle; 137 - /* Pad, must be zero-filled. */ 122 + /** 123 + * @pad: Padding, must be zero-filled. 124 + */ 138 125 __u32 pad; 139 126 /** 140 - * Returned offset for the BO in the GPU address space. This offset 141 - * is private to the DRM fd and is valid for the lifetime of the GEM 142 - * handle. 127 + * @offset: Returned offset for the BO in the GPU address space. 128 + * This offset is private to the DRM fd and is valid for the 129 + * lifetime of the GEM handle. 143 130 * 144 131 * This offset value will always be nonzero, since various HW 145 132 * units treat 0 specially. ··· 169 136 * used in a future extension. 170 137 */ 171 138 struct drm_panfrost_mmap_bo { 172 - /** Handle for the object being mapped. */ 139 + /** 140 + * @handle: Handle for the object being mapped. 141 + */ 173 142 __u32 handle; 143 + /** 144 + * @flags: currently not used (should be zero) 145 + */ 174 146 __u32 flags; 175 - /** offset into the drm node to use for subsequent mmap call. */ 147 + /** 148 + * @offset: offset into the drm node to use for subsequent mmap call. 149 + */ 176 150 __u64 offset; 177 151 }; 178 152 ··· 236 196 __u64 value; 237 197 }; 238 198 239 - /** 199 + /* 240 200 * Returns the offset for the BO in the GPU address space for this DRM fd. 241 201 * This is the same value returned by drm_panfrost_create_bo, if that was called 242 202 * from this DRM fd. ··· 284 244 * struct drm_panfrost_set_label_bo - ioctl argument for labelling Panfrost BOs. 285 245 */ 286 246 struct drm_panfrost_set_label_bo { 287 - /** @handle: Handle of the buffer object to label. */ 247 + /** 248 + * @handle: Handle of the buffer object to label. 249 + */ 288 250 __u32 handle; 289 - 290 - /** @pad: MBZ. */ 251 + /** 252 + * @pad: Must be zero. 253 + */ 291 254 __u32 pad; 292 - 293 255 /** 294 256 * @label: User pointer to a NUL-terminated string 295 257 * ··· 372 330 }; 373 331 374 332 struct drm_panfrost_jm_ctx_create { 375 - /** @handle: Handle of the created JM context */ 333 + /** 334 + * @handle: Handle of the created JM context 335 + */ 376 336 __u32 handle; 377 - 378 - /** @priority: Context priority (see enum drm_panfrost_jm_ctx_priority). */ 337 + /** 338 + * @priority: Context priority (see enum drm_panfrost_jm_ctx_priority). 339 + */ 379 340 __u32 priority; 380 341 }; 381 342 ··· 389 344 * Must be a valid context handle returned by DRM_IOCTL_PANTHOR_JM_CTX_CREATE. 390 345 */ 391 346 __u32 handle; 392 - 393 - /** @pad: Padding field, MBZ. */ 347 + /** 348 + * @pad: Padding field, must be zero. 349 + */ 394 350 __u32 pad; 395 351 }; 396 352