Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

lib/math/rational: add Kunit test cases

Adds a number of test cases that cover a range of possible code paths.

[akpm@linux-foundation.org: remove non-ascii characters, fix whitespace]
[colin.king@canonical.com: fix spelling mistake "demominator" -> "denominator"]
Link: https://lkml.kernel.org/r/20210526085049.6393-1-colin.king@canonical.com

Link: https://lkml.kernel.org/r/20210525144250.214670-2-tpiepho@gmail.com
Signed-off-by: Trent Piepho <tpiepho@gmail.com>
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Daniel Latypov <dlatypov@google.com>
Cc: Oskar Schirmer <oskar@scara.com>
Cc: Yiyuan Guo <yguoaz@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

authored by

Trent Piepho and committed by
Linus Torvalds
b6c75c4a 65a0d3c1

+69
+12
lib/Kconfig.debug
··· 2444 2444 2445 2445 If unsure, say N. 2446 2446 2447 + config RATIONAL_KUNIT_TEST 2448 + tristate "KUnit test for rational.c" if !KUNIT_ALL_TESTS 2449 + depends on KUNIT 2450 + select RATIONAL 2451 + default KUNIT_ALL_TESTS 2452 + help 2453 + This builds the rational math unit test. 2454 + For more information on KUnit and unit tests in general please refer 2455 + to the KUnit documentation in Documentation/dev-tools/kunit/. 2456 + 2457 + If unsure, say N. 2458 + 2447 2459 config TEST_UDELAY 2448 2460 tristate "udelay test driver" 2449 2461 help
+1
lib/math/Makefile
··· 6 6 obj-$(CONFIG_RATIONAL) += rational.o 7 7 8 8 obj-$(CONFIG_TEST_DIV64) += test_div64.o 9 + obj-$(CONFIG_RATIONAL_KUNIT_TEST) += rational-test.o
+56
lib/math/rational-test.c
··· 1 + // SPDX-License-Identifier: GPL-2.0 2 + 3 + #include <kunit/test.h> 4 + 5 + #include <linux/rational.h> 6 + 7 + struct rational_test_param { 8 + unsigned long num, den; 9 + unsigned long max_num, max_den; 10 + unsigned long exp_num, exp_den; 11 + 12 + const char *name; 13 + }; 14 + 15 + static const struct rational_test_param test_parameters[] = { 16 + { 1230, 10, 100, 20, 100, 1, "Exceeds bounds, semi-convergent term > 1/2 last term" }, 17 + { 34567,100, 120, 20, 120, 1, "Exceeds bounds, semi-convergent term < 1/2 last term" }, 18 + { 1, 30, 100, 10, 0, 1, "Closest to zero" }, 19 + { 1, 19, 100, 10, 1, 10, "Closest to smallest non-zero" }, 20 + { 27,32, 16, 16, 11, 13, "Use convergent" }, 21 + { 1155, 7735, 255, 255, 33, 221, "Exact answer" }, 22 + { 87, 32, 70, 32, 68, 25, "Semiconvergent, numerator limit" }, 23 + { 14533, 4626, 15000, 2400, 7433, 2366, "Semiconvergent, denominator limit" }, 24 + }; 25 + 26 + static void get_desc(const struct rational_test_param *param, char *desc) 27 + { 28 + strscpy(desc, param->name, KUNIT_PARAM_DESC_SIZE); 29 + } 30 + 31 + /* Creates function rational_gen_params */ 32 + KUNIT_ARRAY_PARAM(rational, test_parameters, get_desc); 33 + 34 + static void rational_test(struct kunit *test) 35 + { 36 + const struct rational_test_param *param = (const struct rational_test_param *)test->param_value; 37 + unsigned long n = 0, d = 0; 38 + 39 + rational_best_approximation(param->num, param->den, param->max_num, param->max_den, &n, &d); 40 + KUNIT_EXPECT_EQ(test, n, param->exp_num); 41 + KUNIT_EXPECT_EQ(test, d, param->exp_den); 42 + } 43 + 44 + static struct kunit_case rational_test_cases[] = { 45 + KUNIT_CASE_PARAM(rational_test, rational_gen_params), 46 + {} 47 + }; 48 + 49 + static struct kunit_suite rational_test_suite = { 50 + .name = "rational", 51 + .test_cases = rational_test_cases, 52 + }; 53 + 54 + kunit_test_suites(&rational_test_suite); 55 + 56 + MODULE_LICENSE("GPL v2");