Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

staging: rtl8723bs: remove sd_f0_read8()

The sd_f0_read8() function, which is used by the sdio_f0_read8()
function, are not used anywhere in the driver and both can be
safely removed.

Signed-off-by: Bryan Brattlof <hello@bryanbrattlof.com>
Link: https://lore.kernel.org/r/20210524195144.1943280-1-hello@bryanbrattlof.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

authored by

Bryan Brattlof and committed by
Greg Kroah-Hartman
b67decf8 a75d6a32

-39
-7
drivers/staging/rtl8723bs/hal/sdio_ops.c
··· 346 346 return err; 347 347 } 348 348 349 - static u8 sdio_f0_read8(struct intf_hdl *intfhdl, u32 addr) 350 - { 351 - return sd_f0_read8(intfhdl, addr, NULL); 352 - } 353 - 354 349 static void sdio_read_mem( 355 350 struct intf_hdl *intfhdl, 356 351 u32 addr, ··· 476 481 ops->_writeN = &sdio_writeN; 477 482 ops->_write_mem = &sdio_write_mem; 478 483 ops->_write_port = &sdio_write_port; 479 - 480 - ops->_sd_f0_read8 = sdio_f0_read8; 481 484 } 482 485 483 486 /*
-2
drivers/staging/rtl8723bs/include/rtw_io.h
··· 104 104 105 105 void (*_read_port_cancel)(struct intf_hdl *pintfhdl); 106 106 void (*_write_port_cancel)(struct intf_hdl *pintfhdl); 107 - 108 - u8 (*_sd_f0_read8)(struct intf_hdl *pintfhdl, u32 addr); 109 107 }; 110 108 111 109 struct io_req {
-2
drivers/staging/rtl8723bs/include/sdio_ops_linux.h
··· 11 11 #define SDIO_ERR_VAL16 0xEAEA 12 12 #define SDIO_ERR_VAL32 0xEAEAEAEA 13 13 14 - u8 sd_f0_read8(struct intf_hdl *pintfhdl, u32 addr, s32 *err); 15 - 16 14 s32 _sd_cmd52_read(struct intf_hdl *pintfhdl, u32 addr, u32 cnt, u8 *pdata); 17 15 s32 _sd_cmd52_write(struct intf_hdl *pintfhdl, u32 addr, u32 cnt, u8 *pdata); 18 16 s32 sd_cmd52_read(struct intf_hdl *pintfhdl, u32 addr, u32 cnt, u8 *pdata);
-28
drivers/staging/rtl8723bs/os_dep/sdio_ops_linux.c
··· 26 26 sdio_data->sys_sdio_irq_thd = thd_hdl; 27 27 } 28 28 29 - u8 sd_f0_read8(struct intf_hdl *pintfhdl, u32 addr, s32 *err) 30 - { 31 - struct adapter *padapter; 32 - struct dvobj_priv *psdiodev; 33 - struct sdio_data *psdio; 34 - 35 - u8 v = 0; 36 - struct sdio_func *func; 37 - bool claim_needed; 38 - 39 - padapter = pintfhdl->padapter; 40 - psdiodev = pintfhdl->pintf_dev; 41 - psdio = &psdiodev->intf_data; 42 - 43 - if (padapter->bSurpriseRemoved) 44 - return v; 45 - 46 - func = psdio->func; 47 - claim_needed = rtw_sdio_claim_host_needed(func); 48 - 49 - if (claim_needed) 50 - sdio_claim_host(func); 51 - v = sdio_f0_readb(func, addr, err); 52 - if (claim_needed) 53 - sdio_release_host(func); 54 - return v; 55 - } 56 - 57 29 /* 58 30 * Return: 59 31 *0 Success