Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

drm: Nuke drm_atomic_helper_crtc_set_property

It's dead code because this is now handled in the core.

Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Cc: Boris Brezillon <boris.brezillon@free-electrons.com>
Cc: Daniel Vetter <daniel.vetter@intel.com>
Cc: Jani Nikula <jani.nikula@linux.intel.com>
Cc: Sean Paul <seanpaul@chromium.org>
Cc: David Airlie <airlied@linux.ie>
Cc: Ben Skeggs <bskeggs@redhat.com>
Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Cc: Alexey Brodkin <abrodkin@synopsys.com>
Cc: Shawn Guo <shawn.guo@linaro.org>
Cc: Eric Engestrom <eric@engestrom.ch>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Cc: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: Rob Clark <robdclark@gmail.com>
Cc: Philippe Cornu <philippe.cornu@st.com>
Cc: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: Sushmita Susheelendra <ssusheel@codeaurora.org>
Cc: Archit Taneja <architt@codeaurora.org>
Cc: intel-gfx@lists.freedesktop.org
Cc: nouveau@lists.freedesktop.org
Cc: Philipp Zabel <p.zabel@pengutronix.de>
Cc: Maxime Ripard <maxime.ripard@free-electrons.com>
Cc: Thomas Hellstrom <thellstrom@vmware.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20170725080122.20548-5-daniel.vetter@ffwll.ch
Reviewed-by: Archit Taneja <architt@codeaurora.org>
Acked-by: Philippe Cornu <philippe.cornu@st.com>
Tested-by: Philippe Cornu <philippe.cornu@st.com>
Reviewed-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Acked-by: Thomas Hellstrom <thellstrom@vmware.com>

-66
-1
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c
··· 431 431 .atomic_destroy_state = atmel_hlcdc_crtc_destroy_state, 432 432 .enable_vblank = atmel_hlcdc_crtc_enable_vblank, 433 433 .disable_vblank = atmel_hlcdc_crtc_disable_vblank, 434 - .set_property = drm_atomic_helper_crtc_set_property, 435 434 .gamma_set = drm_atomic_helper_legacy_gamma_set, 436 435 }; 437 436
-55
drivers/gpu/drm/drm_atomic_helper.c
··· 2954 2954 EXPORT_SYMBOL(drm_atomic_helper_resume); 2955 2955 2956 2956 /** 2957 - * drm_atomic_helper_crtc_set_property - helper for crtc properties 2958 - * @crtc: DRM crtc 2959 - * @property: DRM property 2960 - * @val: value of property 2961 - * 2962 - * Provides a default crtc set_property handler using the atomic driver 2963 - * interface. 2964 - * 2965 - * RETURNS: 2966 - * Zero on success, error code on failure 2967 - */ 2968 - int 2969 - drm_atomic_helper_crtc_set_property(struct drm_crtc *crtc, 2970 - struct drm_property *property, 2971 - uint64_t val) 2972 - { 2973 - struct drm_atomic_state *state; 2974 - struct drm_crtc_state *crtc_state; 2975 - int ret = 0; 2976 - 2977 - state = drm_atomic_state_alloc(crtc->dev); 2978 - if (!state) 2979 - return -ENOMEM; 2980 - 2981 - /* ->set_property is always called with all locks held. */ 2982 - state->acquire_ctx = crtc->dev->mode_config.acquire_ctx; 2983 - retry: 2984 - crtc_state = drm_atomic_get_crtc_state(state, crtc); 2985 - if (IS_ERR(crtc_state)) { 2986 - ret = PTR_ERR(crtc_state); 2987 - goto fail; 2988 - } 2989 - 2990 - ret = drm_atomic_crtc_set_property(crtc, crtc_state, 2991 - property, val); 2992 - if (ret) 2993 - goto fail; 2994 - 2995 - ret = drm_atomic_commit(state); 2996 - fail: 2997 - if (ret == -EDEADLK) 2998 - goto backoff; 2999 - 3000 - drm_atomic_state_put(state); 3001 - return ret; 3002 - 3003 - backoff: 3004 - drm_atomic_state_clear(state); 3005 - drm_atomic_legacy_backoff(state); 3006 - 3007 - goto retry; 3008 - } 3009 - EXPORT_SYMBOL(drm_atomic_helper_crtc_set_property); 3010 - 3011 - /** 3012 2957 * drm_atomic_helper_plane_set_property - helper for plane properties 3013 2958 * @plane: DRM plane 3014 2959 * @property: DRM property
-1
drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c
··· 567 567 .set_config = drm_atomic_helper_set_config, 568 568 .page_flip = drm_atomic_helper_page_flip, 569 569 .reset = drm_atomic_helper_crtc_reset, 570 - .set_property = drm_atomic_helper_crtc_set_property, 571 570 .atomic_duplicate_state = drm_atomic_helper_crtc_duplicate_state, 572 571 .atomic_destroy_state = drm_atomic_helper_crtc_destroy_state, 573 572 .enable_vblank = ade_crtc_enable_vblank,
-1
drivers/gpu/drm/i915/intel_display.c
··· 13323 13323 static const struct drm_crtc_funcs intel_crtc_funcs = { 13324 13324 .gamma_set = drm_atomic_helper_legacy_gamma_set, 13325 13325 .set_config = drm_atomic_helper_set_config, 13326 - .set_property = drm_atomic_helper_crtc_set_property, 13327 13326 .destroy = intel_crtc_destroy, 13328 13327 .page_flip = drm_atomic_helper_page_flip, 13329 13328 .atomic_duplicate_state = intel_crtc_duplicate_state,
-1
drivers/gpu/drm/msm/mdp/mdp4/mdp4_crtc.c
··· 484 484 .set_config = drm_atomic_helper_set_config, 485 485 .destroy = mdp4_crtc_destroy, 486 486 .page_flip = drm_atomic_helper_page_flip, 487 - .set_property = drm_atomic_helper_crtc_set_property, 488 487 .cursor_set = mdp4_crtc_cursor_set, 489 488 .cursor_move = mdp4_crtc_cursor_move, 490 489 .reset = drm_atomic_helper_crtc_reset,
-2
drivers/gpu/drm/msm/mdp/mdp5/mdp5_crtc.c
··· 919 919 .set_config = drm_atomic_helper_set_config, 920 920 .destroy = mdp5_crtc_destroy, 921 921 .page_flip = drm_atomic_helper_page_flip, 922 - .set_property = drm_atomic_helper_crtc_set_property, 923 922 .reset = mdp5_crtc_reset, 924 923 .atomic_duplicate_state = mdp5_crtc_duplicate_state, 925 924 .atomic_destroy_state = mdp5_crtc_destroy_state, ··· 931 932 .set_config = drm_atomic_helper_set_config, 932 933 .destroy = mdp5_crtc_destroy, 933 934 .page_flip = drm_atomic_helper_page_flip, 934 - .set_property = drm_atomic_helper_crtc_set_property, 935 935 .reset = mdp5_crtc_reset, 936 936 .atomic_duplicate_state = mdp5_crtc_duplicate_state, 937 937 .atomic_destroy_state = mdp5_crtc_destroy_state,
-1
drivers/gpu/drm/nouveau/nv50_display.c
··· 2318 2318 .destroy = nv50_head_destroy, 2319 2319 .set_config = drm_atomic_helper_set_config, 2320 2320 .page_flip = drm_atomic_helper_page_flip, 2321 - .set_property = drm_atomic_helper_crtc_set_property, 2322 2321 .atomic_duplicate_state = nv50_head_atomic_duplicate_state, 2323 2322 .atomic_destroy_state = nv50_head_atomic_destroy_state, 2324 2323 };
-1
drivers/gpu/drm/omapdrm/omap_crtc.c
··· 604 604 .destroy = omap_crtc_destroy, 605 605 .page_flip = drm_atomic_helper_page_flip, 606 606 .gamma_set = drm_atomic_helper_legacy_gamma_set, 607 - .set_property = drm_atomic_helper_crtc_set_property, 608 607 .atomic_duplicate_state = omap_crtc_duplicate_state, 609 608 .atomic_destroy_state = drm_atomic_helper_crtc_destroy_state, 610 609 .atomic_set_property = omap_crtc_atomic_set_property,
-3
include/drm/drm_atomic_helper.h
··· 124 124 int drm_atomic_helper_resume(struct drm_device *dev, 125 125 struct drm_atomic_state *state); 126 126 127 - int drm_atomic_helper_crtc_set_property(struct drm_crtc *crtc, 128 - struct drm_property *property, 129 - uint64_t val); 130 127 int drm_atomic_helper_plane_set_property(struct drm_plane *plane, 131 128 struct drm_property *property, 132 129 uint64_t val);