Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

ARM: dts: sun8i-a83t-tbs-a711: Fix USB OTG mode detection

USB-ID signal has a pullup on the schematic, but in reality it's not
pulled up, so add a GPIO pullup. And we also need a usb0_vbus_power-supply
for VBUS detection.

This fixes OTG mode detection and charging issues on TBS A711 tablet.
The issues came from ID pin reading 0, causing host mode to be enabled,
when it should not be, leading to DRVVBUS being enabled, which disabled
the charger.

Fixes: f2f221c7810b824e ("ARM: dts: sun8i: a711: Enable USB OTG")
Signed-off-by: Ondrej Jirman <megous@megous.com>
Signed-off-by: Maxime Ripard <maxime@cerno.tech>

authored by

Ondrej Jirman and committed by
Maxime Ripard
b642d482 a4055095

+2 -1
+2 -1
arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts
··· 498 498 }; 499 499 500 500 &usbphy { 501 - usb0_id_det-gpios = <&pio 7 11 GPIO_ACTIVE_HIGH>; /* PH11 */ 501 + usb0_id_det-gpios = <&pio 7 11 (GPIO_ACTIVE_HIGH | GPIO_PULL_UP)>; /* PH11 */ 502 + usb0_vbus_power-supply = <&usb_power_supply>; 502 503 usb0_vbus-supply = <&reg_drivevbus>; 503 504 usb1_vbus-supply = <&reg_vmain>; 504 505 usb2_vbus-supply = <&reg_vmain>;