Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

media: bcm2835-unicam: Fix a NULL vs IS_ERR() check

The media_pad_remote_pad_unique() function returns error pointers, not
NULL. Update the check accordingly.

Fixes: 392cd78d495f ("media: bcm2835-unicam: Add support for CCP2/CSI2 camera interface")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Link: https://lore.kernel.org/r/fbbe7862-2820-44eb-81cb-7f33b99cca35@moroto.mountain
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

authored by

Dan Carpenter and committed by
Laurent Pinchart
b6041c9e 0cc50ced

+2 -2
+2 -2
drivers/media/platform/broadcom/bcm2835-unicam.c
··· 2433 2433 return ret; 2434 2434 2435 2435 source = media_pad_remote_pad_unique(sink); 2436 - if (!source) { 2436 + if (IS_ERR(source)) { 2437 2437 dev_err(unicam->dev, "No connected sensor pad\n"); 2438 - return -ENOTCONN; 2438 + return PTR_ERR(source); 2439 2439 } 2440 2440 2441 2441 unicam->sensor.subdev = subdev;