Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

soc: qcom: ocmem: fix device leak on lookup

Make sure to drop the reference taken to the ocmem platform device when
looking up its driver data.

Note that holding a reference to a device does not prevent its driver
data from going away so there is no point in keeping the reference.

Also note that commit 0ff027027e05 ("soc: qcom: ocmem: Fix missing
put_device() call in of_get_ocmem") fixed the leak in a lookup error
path, but the reference is still leaking on success.

Fixes: 88c1e9404f1d ("soc: qcom: add OCMEM driver")
Cc: stable@vger.kernel.org # 5.5: 0ff027027e05
Cc: Brian Masney <bmasney@redhat.com>
Cc: Miaoqian Lin <linmq006@gmail.com>
Signed-off-by: Johan Hovold <johan@kernel.org>
Reviewed-by: Brian Masney <bmasney@redhat.com>
Link: https://lore.kernel.org/r/20250926143511.6715-2-johan@kernel.org
Signed-off-by: Bjorn Andersson <andersson@kernel.org>

authored by

Johan Hovold and committed by
Bjorn Andersson
b5c16ea5 c88b6ee3

+1 -1
+1 -1
drivers/soc/qcom/ocmem.c
··· 202 202 } 203 203 204 204 ocmem = platform_get_drvdata(pdev); 205 + put_device(&pdev->dev); 205 206 if (!ocmem) { 206 207 dev_err(dev, "Cannot get ocmem\n"); 207 - put_device(&pdev->dev); 208 208 return ERR_PTR(-ENODEV); 209 209 } 210 210 return ocmem;