Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

gpio: ftgpio010: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.

To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new(), which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

authored by

Uwe Kleine-König and committed by
Bartosz Golaszewski
b57d8416 6a277ca7

+2 -4
+2 -4
drivers/gpio/gpio-ftgpio010.c
··· 324 324 return ret; 325 325 } 326 326 327 - static int ftgpio_gpio_remove(struct platform_device *pdev) 327 + static void ftgpio_gpio_remove(struct platform_device *pdev) 328 328 { 329 329 struct ftgpio_gpio *g = platform_get_drvdata(pdev); 330 330 331 331 clk_disable_unprepare(g->clk); 332 - 333 - return 0; 334 332 } 335 333 336 334 static const struct of_device_id ftgpio_gpio_of_match[] = { ··· 350 352 .of_match_table = ftgpio_gpio_of_match, 351 353 }, 352 354 .probe = ftgpio_gpio_probe, 353 - .remove = ftgpio_gpio_remove, 355 + .remove_new = ftgpio_gpio_remove, 354 356 }; 355 357 builtin_platform_driver(ftgpio_gpio_driver);