Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

platform/chrome: cros_ec_lpc: Handle zero length read/write

cros_ec_lpc_mec_read_bytes and cros_ec_lpc_mec_write_bytes call
cros_ec_lpc_mec_in_range, which checks if addresses are in the MEC
address range, and returns -EINVAL if the range given is not sensible.

However cros_ec_lpc_mec_in_range was also returning -EINVAL for a zero
length range.

A zero length range should not be an error condition.
cros_ec_lpc_mec_in_range now returns 1 in this case.
cros_ec_lpc_io_bytes_mec checks for zero length, and returns
immediately without beginning a transfer.

Fixes: 68dbac0a58ef ("platform/chrome: cros_ec_lpc: MEC access can return error code")
Fixes: 77a714325d09 ("platform/chrome: cros_ec_lpc: Fix error code in cros_ec_lpc_mec_read_bytes()")
Signed-off-by: Ben Walsh <ben@jubnut.com>
Link: https://lore.kernel.org/r/20240613212542.403-1-ben@jubnut.com
Signed-off-by: Tzung-Bi Shih <tzungbi@kernel.org>

authored by

Ben Walsh and committed by
Tzung-Bi Shih
b57cd570 77a71432

+3 -3
+3 -3
drivers/platform/chrome/cros_ec_lpc_mec.c
··· 93 93 */ 94 94 int cros_ec_lpc_mec_in_range(unsigned int offset, unsigned int length) 95 95 { 96 - if (length == 0) 97 - return -EINVAL; 98 - 99 96 if (WARN_ON(mec_emi_base == 0 || mec_emi_end == 0)) 100 97 return -EINVAL; 101 98 ··· 128 131 u8 sum = 0; 129 132 enum cros_ec_lpc_mec_emi_access_mode access, new_access; 130 133 int ret; 134 + 135 + if (length == 0) 136 + return 0; 131 137 132 138 /* Return checksum of 0 if window is not initialized */ 133 139 WARN_ON(mec_emi_base == 0 || mec_emi_end == 0);