Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

staging: rtl8192e: Fix use after free in _rtl92e_pci_disconnect()

The free_rtllib() function frees the "dev" pointer so there is use
after free on the next line. Re-arrange things to avoid that.

Fixes: 66898177e7e5 ("staging: rtl8192e: Fix unload/reload problem")
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/20211117072016.GA5237@kili
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

authored by

Dan Carpenter and committed by
Greg Kroah-Hartman
b535917c ffcf7ae9

+2 -1
+2 -1
drivers/staging/rtl8192e/rtl8192e/rtl_core.c
··· 2549 2549 free_irq(dev->irq, dev); 2550 2550 priv->irq = 0; 2551 2551 } 2552 - free_rtllib(dev); 2553 2552 2554 2553 if (dev->mem_start != 0) { 2555 2554 iounmap((void __iomem *)dev->mem_start); 2556 2555 release_mem_region(pci_resource_start(pdev, 1), 2557 2556 pci_resource_len(pdev, 1)); 2558 2557 } 2558 + 2559 + free_rtllib(dev); 2559 2560 } 2560 2561 2561 2562 pci_disable_device(pdev);