Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

spi: sc18is602: Support multiple devices on a single I2C bus if DT is configured

The driver currently only supports a single device per I2C bus since it uses
the I2C bus number to set the SPI bus number. This makes it impossible to
connect more than one chip to a single I2C bus.

We don't want to use dynamic bus numbers unconditionally since this would
result in every instantiation getting a different bus number starting with
65,535 counting down unless devicetree is configured. If devicetree is
configured, however, the SPI bus number is obtained from devicetree
data. So we can use dynamic SPI bus numbers in this case.

Reported-and-Tested-by: Marco Menchise <marco.menchise@gmail.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Mark Brown <broonie@kernel.org>

authored by

Guenter Roeck and committed by
Mark Brown
b4e27545 bfa76d49

+1 -1
+1 -1
drivers/spi/spi-sc18is602.c
··· 290 290 hw->freq = SC18IS602_CLOCK; 291 291 break; 292 292 } 293 - master->bus_num = client->adapter->nr; 293 + master->bus_num = np ? -1 : client->adapter->nr; 294 294 master->mode_bits = SPI_CPHA | SPI_CPOL | SPI_LSB_FIRST; 295 295 master->bits_per_word_mask = SPI_BPW_MASK(8); 296 296 master->setup = sc18is602_setup;