objtool: Check for gelf_update_rel[a] failures

Otherwise, if these fail we end up with garbage data in the
.rela.orc_unwind_ip section, leading to errors like

ld: fs/squashfs/namei.o: bad reloc symbol index (0x7f16 >= 0x12) for offset 0x7f16d5c82cc8 in section `.orc_unwind_ip'

Signed-off-by: Michael Forney <mforney@mforney.org>
Reviewed-by: Miroslav Benes <mbenes@suse.cz>
Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
Link: https://lore.kernel.org/r/20210509000103.11008-1-mforney@mforney.org

authored by Michael Forney and committed by Josh Poimboeuf b46179d6 fe255fe6

+8 -2
+8 -2
tools/objtool/elf.c
··· 1001 list_for_each_entry(reloc, &sec->reloc_list, list) { 1002 reloc->rel.r_offset = reloc->offset; 1003 reloc->rel.r_info = GELF_R_INFO(reloc->sym->idx, reloc->type); 1004 - gelf_update_rel(sec->data, idx, &reloc->rel); 1005 idx++; 1006 } 1007 ··· 1036 reloc->rela.r_offset = reloc->offset; 1037 reloc->rela.r_addend = reloc->addend; 1038 reloc->rela.r_info = GELF_R_INFO(reloc->sym->idx, reloc->type); 1039 - gelf_update_rela(sec->data, idx, &reloc->rela); 1040 idx++; 1041 } 1042
··· 1001 list_for_each_entry(reloc, &sec->reloc_list, list) { 1002 reloc->rel.r_offset = reloc->offset; 1003 reloc->rel.r_info = GELF_R_INFO(reloc->sym->idx, reloc->type); 1004 + if (!gelf_update_rel(sec->data, idx, &reloc->rel)) { 1005 + WARN_ELF("gelf_update_rel"); 1006 + return -1; 1007 + } 1008 idx++; 1009 } 1010 ··· 1033 reloc->rela.r_offset = reloc->offset; 1034 reloc->rela.r_addend = reloc->addend; 1035 reloc->rela.r_info = GELF_R_INFO(reloc->sym->idx, reloc->type); 1036 + if (!gelf_update_rela(sec->data, idx, &reloc->rela)) { 1037 + WARN_ELF("gelf_update_rela"); 1038 + return -1; 1039 + } 1040 idx++; 1041 } 1042