btrfs: Fix quota reservation leak on preallocated files

Commit c6887cd11149 ("Btrfs: don't do nocow check unless we have to")
changed the behavior of __btrfs_buffered_write() so that it first tries
to get a data space reservation, and then skips the relatively expensive
nocow check if the reservation succeeded.

If we have quotas enabled, the data space reservation also includes a
quota reservation. But in the rewrite case, the space has already been
accounted for in qgroups. So btrfs_check_data_free_space() increases
the quota reservation, but it never gets decreased when the data
actually gets written and overwrites the pre-existing data. So we're
left with both the qgroup and qgroup reservation accounting for the same
space.

This commit adds the missing btrfs_qgroup_free_data() call in the case
of BTRFS_ORDERED_PREALLOC extents.

Fixes: c6887cd11149 ("Btrfs: don't do nocow check unless we have to")
Signed-off-by: Justin Maggard <jmaggard@netgear.com>
Reviewed-by: Qu Wenruo <wqu@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>

authored by

Justin Maggard and committed by
David Sterba
b430b775 ea37d599

+2
+2
fs/btrfs/inode.c
··· 3005 3005 compress_type = ordered_extent->compress_type; 3006 3006 if (test_bit(BTRFS_ORDERED_PREALLOC, &ordered_extent->flags)) { 3007 3007 BUG_ON(compress_type); 3008 + btrfs_qgroup_free_data(inode, NULL, ordered_extent->file_offset, 3009 + ordered_extent->len); 3008 3010 ret = btrfs_mark_extent_written(trans, BTRFS_I(inode), 3009 3011 ordered_extent->file_offset, 3010 3012 ordered_extent->file_offset +