Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

greybus: core: add device prefix to error messages

Use dev_err and dev_warn where appropriate and remove now unused pr_fmt
defines.

Testing Done:
Tested on DB3.5 with the generic bridge firmware on APB2.

Signed-off-by: Johan Hovold <johan@hovoldconsulting.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@google.com>

authored by

Johan Hovold and committed by
Greg Kroah-Hartman
b427572e a0b5542d

+2 -6
-2
drivers/staging/greybus/debugfs.c
··· 7 7 * Released under the GPLv2 only. 8 8 */ 9 9 10 - #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt 11 - 12 10 #include <linux/debugfs.h> 13 11 14 12 #include "greybus.h"
+1 -3
drivers/staging/greybus/hd.c
··· 7 7 * Released under the GPLv2 only. 8 8 */ 9 9 10 - #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt 11 - 12 10 #include <linux/kernel.h> 13 11 #include <linux/slab.h> 14 12 ··· 53 55 * so that we don't have to every time we make them. 54 56 */ 55 57 if ((!driver->message_send) || (!driver->message_cancel)) { 56 - pr_err("Must implement all gb_hd_driver callbacks!\n"); 58 + dev_err(parent, "mandatory hd-callbacks missing\n"); 57 59 return ERR_PTR(-EINVAL); 58 60 } 59 61
+1 -1
drivers/staging/greybus/operation.c
··· 327 327 size_t message_size = payload_size + sizeof(*header); 328 328 329 329 if (message_size > hd->buffer_size_max) { 330 - pr_warn("requested message size too big (%zu > %zu)\n", 330 + dev_warn(&hd->dev, "requested message size too big (%zu > %zu)\n", 331 331 message_size, hd->buffer_size_max); 332 332 return NULL; 333 333 }