Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

phy: rockchip: phy-rockchip-inno-csidphy: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
Link: https://lore.kernel.org/r/20230307115900.2293120-20-u.kleine-koenig@pengutronix.de
Signed-off-by: Vinod Koul <vkoul@kernel.org>

authored by

Uwe Kleine-König and committed by
Vinod Koul
b41f07b2 f1c01b91

+2 -4
+2 -4
drivers/phy/rockchip/phy-rockchip-inno-csidphy.c
··· 459 459 return 0; 460 460 } 461 461 462 - static int rockchip_inno_csidphy_remove(struct platform_device *pdev) 462 + static void rockchip_inno_csidphy_remove(struct platform_device *pdev) 463 463 { 464 464 struct rockchip_inno_csidphy *priv = platform_get_drvdata(pdev); 465 465 466 466 pm_runtime_disable(priv->dev); 467 - 468 - return 0; 469 467 } 470 468 471 469 static struct platform_driver rockchip_inno_csidphy_driver = { ··· 472 474 .of_match_table = rockchip_inno_csidphy_match_id, 473 475 }, 474 476 .probe = rockchip_inno_csidphy_probe, 475 - .remove = rockchip_inno_csidphy_remove, 477 + .remove_new = rockchip_inno_csidphy_remove, 476 478 }; 477 479 478 480 module_platform_driver(rockchip_inno_csidphy_driver);