Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

drm/sun4i: dsi: Make use of the helper function dev_err_probe()

When possible use dev_err_probe help to properly deal with the
PROBE_DEFER error, the benefit is that DEFER issue will be logged
in the devices_deferred debugfs file.
And using dev_err_probe() can reduce code size, the error value
gets printed.

Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
Link: https://patchwork.freedesktop.org/patch/msgid/20210916105625.12109-1-caihuoqing@baidu.com

authored by

Cai Huoqing and committed by
Maxime Ripard
b41e24a5 e4f86819

+6 -8
+6 -8
drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c
··· 1126 1126 } 1127 1127 1128 1128 dsi->regulator = devm_regulator_get(dev, "vcc-dsi"); 1129 - if (IS_ERR(dsi->regulator)) { 1130 - dev_err(dev, "Couldn't get VCC-DSI supply\n"); 1131 - return PTR_ERR(dsi->regulator); 1132 - } 1129 + if (IS_ERR(dsi->regulator)) 1130 + return dev_err_probe(dev, PTR_ERR(dsi->regulator), 1131 + "Couldn't get VCC-DSI supply\n"); 1133 1132 1134 1133 dsi->reset = devm_reset_control_get_shared(dev, NULL); 1135 1134 if (IS_ERR(dsi->reset)) { ··· 1143 1144 } 1144 1145 1145 1146 dsi->bus_clk = devm_clk_get(dev, bus_clk_name); 1146 - if (IS_ERR(dsi->bus_clk)) { 1147 - dev_err(dev, "Couldn't get the DSI bus clock\n"); 1148 - return PTR_ERR(dsi->bus_clk); 1149 - } 1147 + if (IS_ERR(dsi->bus_clk)) 1148 + return dev_err_probe(dev, PTR_ERR(dsi->bus_clk), 1149 + "Couldn't get the DSI bus clock\n"); 1150 1150 1151 1151 ret = regmap_mmio_attach_clk(dsi->regs, dsi->bus_clk); 1152 1152 if (ret)