Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

[PATCH] paride_register(): shuffle return values

paride_register() returns 1 on success, 0 on failure and module init
code looks like

static int __init foo_init(void)
{
return paride_register(&foo) - 1;
}

which is not what one get used to. Converted to usual 0/-E convention.

In case of kbic driver, unwind registration. It was just

return (paride_register(&k951)||paride_register(&k971))-1;

Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

authored by

Alexey Dobriyan and committed by
Linus Torvalds
b4178ab5 f4330002

+26 -18
+1 -1
drivers/block/paride/aten.c
··· 149 149 150 150 static int __init aten_init(void) 151 151 { 152 - return paride_register(&aten)-1; 152 + return paride_register(&aten); 153 153 } 154 154 155 155 static void __exit aten_exit(void)
+1 -1
drivers/block/paride/bpck.c
··· 464 464 465 465 static int __init bpck_init(void) 466 466 { 467 - return paride_register(&bpck)-1; 467 + return paride_register(&bpck); 468 468 } 469 469 470 470 static void __exit bpck_exit(void)
+1 -1
drivers/block/paride/bpck6.c
··· 265 265 printk(KERN_INFO "bpck6: Copyright 2001 by Micro Solutions, Inc., DeKalb IL. USA\n"); 266 266 if(verbose) 267 267 printk(KERN_DEBUG "bpck6: verbose debug enabled.\n"); 268 - return paride_register(&bpck6) - 1; 268 + return paride_register(&bpck6); 269 269 } 270 270 271 271 static void __exit bpck6_exit(void)
+1 -1
drivers/block/paride/comm.c
··· 205 205 206 206 static int __init comm_init(void) 207 207 { 208 - return paride_register(&comm)-1; 208 + return paride_register(&comm); 209 209 } 210 210 211 211 static void __exit comm_exit(void)
+1 -1
drivers/block/paride/dstr.c
··· 220 220 221 221 static int __init dstr_init(void) 222 222 { 223 - return paride_register(&dstr)-1; 223 + return paride_register(&dstr); 224 224 } 225 225 226 226 static void __exit dstr_exit(void)
+1 -1
drivers/block/paride/epat.c
··· 327 327 #ifdef CONFIG_PARIDE_EPATC8 328 328 epatc8 = 1; 329 329 #endif 330 - return paride_register(&epat)-1; 330 + return paride_register(&epat); 331 331 } 332 332 333 333 static void __exit epat_exit(void)
+1 -1
drivers/block/paride/epia.c
··· 303 303 304 304 static int __init epia_init(void) 305 305 { 306 - return paride_register(&epia)-1; 306 + return paride_register(&epia); 307 307 } 308 308 309 309 static void __exit epia_exit(void)
+1 -1
drivers/block/paride/fit2.c
··· 138 138 139 139 static int __init fit2_init(void) 140 140 { 141 - return paride_register(&fit2)-1; 141 + return paride_register(&fit2); 142 142 } 143 143 144 144 static void __exit fit2_exit(void)
+1 -1
drivers/block/paride/fit3.c
··· 198 198 199 199 static int __init fit3_init(void) 200 200 { 201 - return paride_register(&fit3)-1; 201 + return paride_register(&fit3); 202 202 } 203 203 204 204 static void __exit fit3_exit(void)
+1 -1
drivers/block/paride/friq.c
··· 263 263 264 264 static int __init friq_init(void) 265 265 { 266 - return paride_register(&friq)-1; 266 + return paride_register(&friq); 267 267 } 268 268 269 269 static void __exit friq_exit(void)
+1 -1
drivers/block/paride/frpw.c
··· 300 300 301 301 static int __init frpw_init(void) 302 302 { 303 - return paride_register(&frpw)-1; 303 + return paride_register(&frpw); 304 304 } 305 305 306 306 static void __exit frpw_exit(void)
+9 -1
drivers/block/paride/kbic.c
··· 283 283 284 284 static int __init kbic_init(void) 285 285 { 286 - return (paride_register(&k951)||paride_register(&k971))-1; 286 + int rv; 287 + 288 + rv = paride_register(&k951); 289 + if (rv < 0) 290 + return rv; 291 + rv = paride_register(&k971); 292 + if (rv < 0) 293 + paride_unregister(&k951); 294 + return rv; 287 295 } 288 296 289 297 static void __exit kbic_exit(void)
+1 -1
drivers/block/paride/ktti.c
··· 115 115 116 116 static int __init ktti_init(void) 117 117 { 118 - return paride_register(&ktti)-1; 118 + return paride_register(&ktti); 119 119 } 120 120 121 121 static void __exit ktti_exit(void)
+1 -1
drivers/block/paride/on20.c
··· 140 140 141 141 static int __init on20_init(void) 142 142 { 143 - return paride_register(&on20)-1; 143 + return paride_register(&on20); 144 144 } 145 145 146 146 static void __exit on20_exit(void)
+1 -1
drivers/block/paride/on26.c
··· 306 306 307 307 static int __init on26_init(void) 308 308 { 309 - return paride_register(&on26)-1; 309 + return paride_register(&on26); 310 310 } 311 311 312 312 static void __exit on26_exit(void)
+3 -3
drivers/block/paride/paride.c
··· 237 237 if (protocols[k] && !strcmp(pr->name, protocols[k]->name)) { 238 238 printk("paride: %s protocol already registered\n", 239 239 pr->name); 240 - return 0; 240 + return -1; 241 241 } 242 242 k = 0; 243 243 while ((k < MAX_PROTOS) && (protocols[k])) 244 244 k++; 245 245 if (k == MAX_PROTOS) { 246 246 printk("paride: protocol table full\n"); 247 - return 0; 247 + return -1; 248 248 } 249 249 protocols[k] = pr; 250 250 pr->index = k; 251 251 printk("paride: %s registered as protocol %d\n", pr->name, k); 252 - return 1; 252 + return 0; 253 253 } 254 254 255 255 EXPORT_SYMBOL(paride_register);