Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

[S390] smp: fix sigp sense handling

sigp sense only returns the status of a cpu if it is non zero. If the
status of the sensed cpu is all zeros condition code 0 (accpeted) is
set and no status bits are returned.
The current code however assumes that a status was returned and tests
bits in it. This means uninitalized data is accessed with random
results.
Worst case is that the code that checks if cpu is offline on cpu
hotplug assumes that the target cpu is offline while it is still
running. This leads potentially to memory corruption since resources
that are still needed by the target cpu will be freed and could be
resused while still in use.

Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>

authored by

Heiko Carstens and committed by
Martin Schwidefsky
b3dcf3de f8501ba7

+1 -1
-1
arch/s390/kernel/smp.c
··· 76 76 __u32 status; 77 77 78 78 switch (signal_processor_ps(&status, 0, cpu, sigp_sense)) { 79 - case sigp_order_code_accepted: 80 79 case sigp_status_stored: 81 80 /* Check for stopped and check stop state */ 82 81 if (status & 0x50)
+1
arch/s390/kernel/swsusp_asm64.S
··· 207 207 llgh %r2,0(%r1) 208 208 7: 209 209 sigp %r9,%r2,__SIGP_SENSE /* Wait for resume CPU */ 210 + brc 8,7b /* accepted, status 0, still running */ 210 211 brc 2,7b /* busy, try again */ 211 212 tmll %r9,0x40 /* Test if resume CPU is stopped */ 212 213 jz 7b