Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

V4L/DVB (9636): dvb: cinergyt2 annotate struct endianness, remove unused variable, add static

All noticed by sparse:
drivers/media/dvb/dvb-usb/cinergyT2-core.c:35:5: warning: symbol 'disable_remote' was not declared. Should it be static?
drivers/media/dvb/dvb-usb/cinergyT2-core.c:48:23: warning: symbol 'cinergyt2_usb_device' was not declared. Should it be static?
drivers/media/dvb/dvb-usb/cinergyT2-fe.c:160:15: warning: cast to restricted __le16
drivers/media/dvb/dvb-usb/cinergyT2-fe.c:190:9: warning: cast to restricted __le32
drivers/media/dvb/dvb-usb/cinergyT2-fe.c:208:9: warning: cast to restricted __le32
drivers/media/dvb/dvb-usb/cinergyT2-fe.c:227:24: warning: cast to restricted __le16
drivers/media/dvb/dvb-usb/cinergyT2-fe.c:275:12: warning: incorrect type in assignment (different base types)
drivers/media/dvb/dvb-usb/cinergyT2-fe.c:275:12: expected unsigned short [unsigned] [assigned] [usertype] tps
drivers/media/dvb/dvb-usb/cinergyT2-fe.c:275:12: got restricted __le16 [usertype] <noident>
drivers/media/dvb/dvb-usb/cinergyT2-fe.c:276:13: warning: incorrect type in assignment (different base types)
drivers/media/dvb/dvb-usb/cinergyT2-fe.c:276:13: expected unsigned int [unsigned] [assigned] [usertype] freq
drivers/media/dvb/dvb-usb/cinergyT2-fe.c:276:13: got restricted __le32 [usertype] <noident>

Cc: Thierry Merle <thierry.merle@free.fr>
Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>

authored by

Harvey Harrison and committed by
Mauro Carvalho Chehab
b3d8466f 726cf200

+6 -7
+1 -2
drivers/media/dvb/dvb-usb/cinergyT2-core.c
··· 32 32 33 33 /* debug */ 34 34 int dvb_usb_cinergyt2_debug; 35 - int disable_remote; 36 35 37 36 module_param_named(debug, dvb_usb_cinergyt2_debug, int, 0644); 38 37 MODULE_PARM_DESC(debug, "set debugging level (1=info, xfer=2, rc=4 " ··· 44 45 }; 45 46 46 47 /* We are missing a release hook with usb_device data */ 47 - struct dvb_usb_device *cinergyt2_usb_device; 48 + static struct dvb_usb_device *cinergyt2_usb_device; 48 49 49 50 static struct dvb_usb_device_properties cinergyt2_properties; 50 51
+5 -5
drivers/media/dvb/dvb-usb/cinergyT2.h
··· 70 70 uint8_t bandwidth; 71 71 uint16_t tps; 72 72 uint8_t flags; 73 - uint16_t gain; 73 + __le16 gain; 74 74 uint8_t snr; 75 - uint32_t viterbi_error_rate; 75 + __le32 viterbi_error_rate; 76 76 uint32_t rs_error_rate; 77 - uint32_t uncorrected_block_count; 77 + __le32 uncorrected_block_count; 78 78 uint8_t lock_bits; 79 79 uint8_t prev_lock_bits; 80 80 } __attribute__((packed)); ··· 82 82 83 83 struct dvbt_set_parameters_msg { 84 84 uint8_t cmd; 85 - uint32_t freq; 85 + __le32 freq; 86 86 uint8_t bandwidth; 87 - uint16_t tps; 87 + __le16 tps; 88 88 uint8_t flags; 89 89 } __attribute__((packed)); 90 90