Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

rtw88: coex: remove unnecessary variable and label

In some funciton, the variable ret just used as return value,and
out label just return ret,so ret and out label are unnecessary,
we should delete these and use return true/false to replace.

Signed-off-by: wengjianfeng <wengjianfeng@yulong.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/20210520005545.31272-1-samirweng1979@163.com

authored by

wengjianfeng and committed by
Kalle Valo
b38678a7 956c6d4f

+10 -30
+10 -30
drivers/net/wireless/realtek/rtw88/coex.c
··· 630 630 struct rtw_coex_info_req req = {0}; 631 631 struct sk_buff *skb; 632 632 u8 *payload; 633 - bool ret = false; 634 633 635 634 req.op_code = BT_MP_INFO_OP_SCAN_TYPE; 636 635 skb = rtw_coex_info_request(rtwdev, &req); 637 636 if (!skb) 638 - goto out; 637 + return false; 639 638 640 639 payload = get_payload_from_coex_resp(skb); 641 640 *scan_type = GET_COEX_RESP_BT_SCAN_TYPE(payload); 642 641 dev_kfree_skb_any(skb); 643 - ret = true; 644 - 645 - out: 646 - return ret; 642 + return true; 647 643 } 648 644 649 645 static bool rtw_coex_set_lna_constrain_level(struct rtw_dev *rtwdev, ··· 647 651 { 648 652 struct rtw_coex_info_req req = {0}; 649 653 struct sk_buff *skb; 650 - bool ret = false; 651 654 652 655 req.op_code = BT_MP_INFO_OP_LNA_CONSTRAINT; 653 656 req.para1 = lna_constrain_level; 654 657 skb = rtw_coex_info_request(rtwdev, &req); 655 658 if (!skb) 656 - goto out; 659 + return false; 657 660 658 661 dev_kfree_skb_any(skb); 659 - ret = true; 660 - 661 - out: 662 - return ret; 662 + return true; 663 663 } 664 664 665 665 #define case_BTSTATUS(src) \ ··· 3525 3533 struct rtw_coex_info_req req = {0}; 3526 3534 struct sk_buff *skb; 3527 3535 u8 *payload; 3528 - bool ret = false; 3529 3536 3530 3537 req.op_code = BT_MP_INFO_OP_PATCH_VER; 3531 3538 skb = rtw_coex_info_request(rtwdev, &req); 3532 3539 if (!skb) 3533 - goto out; 3540 + return false; 3534 3541 3535 3542 payload = get_payload_from_coex_resp(skb); 3536 3543 *patch_version = GET_COEX_RESP_BT_PATCH_VER(payload); 3537 - ret = true; 3538 - 3539 - out: 3540 - return ret; 3544 + return true; 3541 3545 } 3542 3546 3543 3547 static bool rtw_coex_get_bt_supported_version(struct rtw_dev *rtwdev, ··· 3542 3554 struct rtw_coex_info_req req = {0}; 3543 3555 struct sk_buff *skb; 3544 3556 u8 *payload; 3545 - bool ret = false; 3546 3557 3547 3558 req.op_code = BT_MP_INFO_OP_SUPP_VER; 3548 3559 skb = rtw_coex_info_request(rtwdev, &req); 3549 3560 if (!skb) 3550 - goto out; 3561 + return false; 3551 3562 3552 3563 payload = get_payload_from_coex_resp(skb); 3553 3564 *supported_version = GET_COEX_RESP_BT_SUPP_VER(payload); 3554 - ret = true; 3555 - 3556 - out: 3557 - return ret; 3565 + return true; 3558 3566 } 3559 3567 3560 3568 static bool rtw_coex_get_bt_supported_feature(struct rtw_dev *rtwdev, ··· 3559 3575 struct rtw_coex_info_req req = {0}; 3560 3576 struct sk_buff *skb; 3561 3577 u8 *payload; 3562 - bool ret = false; 3563 3578 3564 3579 req.op_code = BT_MP_INFO_OP_SUPP_FEAT; 3565 3580 skb = rtw_coex_info_request(rtwdev, &req); 3566 3581 if (!skb) 3567 - goto out; 3582 + return false; 3568 3583 3569 3584 payload = get_payload_from_coex_resp(skb); 3570 3585 *supported_feature = GET_COEX_RESP_BT_SUPP_FEAT(payload); 3571 - ret = true; 3572 - 3573 - out: 3574 - return ret; 3586 + return true; 3575 3587 } 3576 3588 3577 3589 struct rtw_coex_sta_stat_iter_data {