Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

iio: dac: ad5764: Fix alignment for DMA safety

____cacheline_aligned is an insufficient guarantee for non-coherent DMA
on platforms with 128 byte cachelines above L1. Switch to the updated
IIO_DMA_MINALIGN definition.

Update the comment to include 'may'.

Fixes: 68b14d7ea956 ("staging:iio:dac: Add AD5764 driver")
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Acked-by: Nuno Sá <nuno.sa@analog.com>
Link: https://lore.kernel.org/r/20220508175712.647246-53-jic23@kernel.org

+2 -2
+2 -2
drivers/iio/dac/ad5764.c
··· 56 56 struct mutex lock; 57 57 58 58 /* 59 - * DMA (thus cache coherency maintenance) requires the 59 + * DMA (thus cache coherency maintenance) may require the 60 60 * transfer buffers to live in their own cache lines. 61 61 */ 62 62 union { 63 63 __be32 d32; 64 64 u8 d8[4]; 65 - } data[2] ____cacheline_aligned; 65 + } data[2] __aligned(IIO_DMA_MINALIGN); 66 66 }; 67 67 68 68 enum ad5764_type {