Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

tpm, tpm_crb: fail when TPM2 ACPI table contents look corrupted

At least some versions of AMI BIOS have corrupted contents in the TPM2
ACPI table and namely the physical address of the control area is set to
zero.

This patch changes the driver to fail gracefully when we observe a zero
address instead of continuing to ioremap.

Cc: <stable@vger.kernel.org>
Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Reviewed-by: Peter Huewe <peterhuewe@gmx.de>
Signed-off-by: Peter Huewe <peterhuewe@gmx.de>

authored by

Jarkko Sakkinen and committed by
Peter Huewe
b371616b ba0ef854

+8
+8
drivers/char/tpm/tpm_crb.c
··· 233 233 return -ENODEV; 234 234 } 235 235 236 + /* At least some versions of AMI BIOS have a bug that TPM2 table has 237 + * zero address for the control area and therefore we must fail. 238 + */ 239 + if (!buf->control_area_pa) { 240 + dev_err(dev, "TPM2 ACPI table has a zero address for the control area\n"); 241 + return -EINVAL; 242 + } 243 + 236 244 if (buf->hdr.length < sizeof(struct acpi_tpm2)) { 237 245 dev_err(dev, "TPM2 ACPI table has wrong size"); 238 246 return -EINVAL;