Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

auxdisplay: small cleanups

- Use BUILD_BUG_ON for CFAG12864B_SIZE instead of runtime-check

- Use get_zeroed_page()

Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
Cc: Miguel Ojeda Sandonis <maxextreme@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

authored by

Akinobu Mita and committed by
Linus Torvalds
b340e8a5 5bb49fcd

+2 -11
+2 -11
drivers/auxdisplay/cfag12864b.c
··· 336 336 "ks0108 is not initialized\n"); 337 337 goto none; 338 338 } 339 + BUILD_BUG_ON(PAGE_SIZE < CFAG12864B_SIZE); 339 340 340 - if (PAGE_SIZE < CFAG12864B_SIZE) { 341 - printk(KERN_ERR CFAG12864B_NAME ": ERROR: " 342 - "page size (%i) < cfag12864b size (%i)\n", 343 - (unsigned int)PAGE_SIZE, CFAG12864B_SIZE); 344 - ret = -ENOMEM; 345 - goto none; 346 - } 347 - 348 - cfag12864b_buffer = (unsigned char *) __get_free_page(GFP_KERNEL); 341 + cfag12864b_buffer = (unsigned char *) get_zeroed_page(GFP_KERNEL); 349 342 if (cfag12864b_buffer == NULL) { 350 343 printk(KERN_ERR CFAG12864B_NAME ": ERROR: " 351 344 "can't get a free page\n"); ··· 359 366 cfag12864b_workqueue = create_singlethread_workqueue(CFAG12864B_NAME); 360 367 if (cfag12864b_workqueue == NULL) 361 368 goto cachealloced; 362 - 363 - memset(cfag12864b_buffer, 0, CFAG12864B_SIZE); 364 369 365 370 cfag12864b_clear(); 366 371 cfag12864b_on();