Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

mdio: mdio-mux-mmioreg: Use of_property_read_reg() to parse "reg"

Use the recently added of_property_read_reg() helper to get the
untranslated "reg" address value.

Signed-off-by: Rob Herring <robh@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>

authored by

Rob Herring and committed by
David S. Miller
b30a1f30 61ab5a06

+4 -3
+4 -3
drivers/net/mdio/mdio-mux-mmioreg.c
··· 140 140 * set any bits outside of the 'mask'. 141 141 */ 142 142 for_each_available_child_of_node(np, np2) { 143 - iprop = of_get_property(np2, "reg", &len); 144 - if (!iprop || len != sizeof(uint32_t)) { 143 + u64 reg; 144 + 145 + if (of_property_read_reg(np2, 0, &reg, NULL)) { 145 146 dev_err(&pdev->dev, "mdio-mux child node %pOF is " 146 147 "missing a 'reg' property\n", np2); 147 148 of_node_put(np2); 148 149 return -ENODEV; 149 150 } 150 - if (be32_to_cpup(iprop) & ~s->mask) { 151 + if ((u32)reg & ~s->mask) { 151 152 dev_err(&pdev->dev, "mdio-mux child node %pOF has " 152 153 "a 'reg' value with unmasked bits\n", 153 154 np2);