Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

drm/amd/display: Fix regamma not affecting full-intensity color values

Hardware understands the regamma LUT as a piecewise linear function,
with points spaced exponentially along the range. We previously
programmed the LUT for range [2^-10, 2^0). This causes (normalized)
color values of 1 (=2^0) to miss the programmed LUT, and fall onto the
end region.

For DCE, the end region is extrapolated using a single (base, slope)
pair, using the max y-value from the last point in the curve as base.
This presents a problem, since this value affects all three color
channels. Scaling down the intensity of say - the blue regamma curve -
will not affect it's end region. This is especially noticiable when
using RedShift. It scales down the blue and green channels, but leaves
full-intensity colors unshifted.

Therefore, extend the range to cover [2^-10, 2^1) by programming another
hardware segment, containing only one point. That way, we won't be
hitting the end region.

Note that things are a bit different for DCN, since the end region can
be set per-channel.

Signed-off-by: Leo (Sunpeng) Li <sunpeng.li@amd.com>
Reviewed-by: Krunoslav Kovac <Krunoslav.Kovac@amd.com>
Acked-by: Harry Wentland <harry.wentland@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

authored by

Leo (Sunpeng) Li and committed by
Alex Deucher
b2f3f592 1409bc6b

+6 -3
+6 -3
drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c
··· 453 453 454 454 } else { 455 455 /* 10 segments 456 - * segment is from 2^-10 to 2^0 456 + * segment is from 2^-10 to 2^1 457 + * We include an extra segment for range [2^0, 2^1). This is to 458 + * ensure that colors with normalized values of 1 don't miss the 459 + * LUT. 457 460 */ 458 461 region_start = -10; 459 - region_end = 0; 462 + region_end = 1; 460 463 461 464 seg_distr[0] = 4; 462 465 seg_distr[1] = 4; ··· 471 468 seg_distr[7] = 4; 472 469 seg_distr[8] = 4; 473 470 seg_distr[9] = 4; 474 - seg_distr[10] = -1; 471 + seg_distr[10] = 0; 475 472 seg_distr[11] = -1; 476 473 seg_distr[12] = -1; 477 474 seg_distr[13] = -1;