Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

module: Prepare to convert all module_param_call() prototypes

After actually converting all module_param_call() function prototypes, we
no longer need to do a tricky sizeof(func(thing)) type-check. Remove it.

Signed-off-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Jessica Yu <jeyu@kernel.org>

authored by

Kees Cook and committed by
Jessica Yu
b2f270e8 9ad04574

+2 -10
+2 -10
include/linux/moduleparam.h
··· 228 228 229 229 /* Obsolete - use module_param_cb() */ 230 230 #define module_param_call(name, set, get, arg, perm) \ 231 - static const struct kernel_param_ops __param_ops_##name = \ 231 + static const struct kernel_param_ops __param_ops_##name = \ 232 232 { .flags = 0, (void *)set, (void *)get }; \ 233 233 __module_param_call(MODULE_PARAM_PREFIX, \ 234 - name, &__param_ops_##name, arg, \ 235 - (perm) + sizeof(__check_old_set_param(set))*0, -1, 0) 236 - 237 - /* We don't get oldget: it's often a new-style param_get_uint, etc. */ 238 - static inline int 239 - __check_old_set_param(int (*oldset)(const char *, struct kernel_param *)) 240 - { 241 - return 0; 242 - } 234 + name, &__param_ops_##name, arg, perm, -1, 0) 243 235 244 236 #ifdef CONFIG_SYSFS 245 237 extern void kernel_param_lock(struct module *mod);