Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

drm/tidss: Use dev_err_probe() over dev_dbg() when failing to probe the port

This gets logged out to /sys/kernel/debug/devices_deferred in the
-EPROBE_DEFER case and as an error otherwise. The message here provides
useful information to the user when troubleshooting why their display is
not working in either case, so let's make it output appropriately.

Signed-off-by: Andrew Halaney <ahalaney@redhat.com>
Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
Tested-by: Enric Balletbo i Serra <eballetbo@kernel.org>
Link: https://lore.kernel.org/r/20240228-tidss-dev-err-probe-v1-1-5482252326d3@redhat.com
Signed-off-by: Maxime Ripard <mripard@kernel.org>

authored by

Andrew Halaney and committed by
Maxime Ripard
b2ec429b e635b7eb

+1 -2
+1 -2
drivers/gpu/drm/tidss/tidss_kms.c
··· 135 135 dev_dbg(dev, "no panel/bridge for port %d\n", i); 136 136 continue; 137 137 } else if (ret) { 138 - dev_dbg(dev, "port %d probe returned %d\n", i, ret); 139 - return ret; 138 + return dev_err_probe(dev, ret, "port %d probe failed\n", i); 140 139 } 141 140 142 141 if (panel) {