Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

extcon: adc-jack: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.

To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new(), which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

LinkL: https://lore.kernel.org/lkml/14d30788ecd288b1b0983a8ea224499bbaa5de19.1708876186.git.u.kleine-koenig@pengutronix.de/
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>

authored by

Uwe Kleine-König and committed by
Chanwoo Choi
b2da7e24 b1a8804f

+2 -4
+2 -4
drivers/extcon/extcon-adc-jack.c
··· 158 158 return 0; 159 159 } 160 160 161 - static int adc_jack_remove(struct platform_device *pdev) 161 + static void adc_jack_remove(struct platform_device *pdev) 162 162 { 163 163 struct adc_jack_data *data = platform_get_drvdata(pdev); 164 164 165 165 free_irq(data->irq, data); 166 166 cancel_work_sync(&data->handler.work); 167 - 168 - return 0; 169 167 } 170 168 171 169 #ifdef CONFIG_PM_SLEEP ··· 194 196 195 197 static struct platform_driver adc_jack_driver = { 196 198 .probe = adc_jack_probe, 197 - .remove = adc_jack_remove, 199 + .remove_new = adc_jack_remove, 198 200 .driver = { 199 201 .name = "adc-jack", 200 202 .pm = &adc_jack_pm_ops,