Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

[media] tda6655: get rid of get_state()/set_state()

Those ops aren't used by any driver, with is weird. I suspect
that mantis_vb3030 driver were not working properly...

Anyway, now that the driver uses the set_parms, the DVB
frontend core should do the right thing.

Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>

-36
-36
drivers/media/dvb-frontends/tda665x.c
··· 66 66 return err; 67 67 } 68 68 69 - static int tda665x_get_state(struct dvb_frontend *fe, 70 - enum tuner_param param, 71 - struct tuner_state *tstate) 72 - { 73 - struct tda665x_state *state = fe->tuner_priv; 74 - int err = 0; 75 - 76 - switch (param) { 77 - case DVBFE_TUNER_FREQUENCY: 78 - tstate->frequency = state->frequency; 79 - break; 80 - case DVBFE_TUNER_BANDWIDTH: 81 - break; 82 - default: 83 - printk(KERN_ERR "%s: Unknown parameter (param=%d)\n", __func__, param); 84 - err = -EINVAL; 85 - break; 86 - } 87 - 88 - return err; 89 - } 90 - 91 69 static int tda665x_get_frequency(struct dvb_frontend *fe, u32 *frequency) 92 70 { 93 71 struct tda665x_state *state = fe->tuner_priv; ··· 197 219 return 0; 198 220 } 199 221 200 - static int tda665x_set_state(struct dvb_frontend *fe, 201 - enum tuner_param param, 202 - struct tuner_state *tstate) 203 - { 204 - if (param & DVBFE_TUNER_FREQUENCY) 205 - return tda665x_set_frequency(fe, tstate->frequency); 206 - 207 - printk(KERN_ERR "%s: Unknown parameter (param=%d)\n", __func__, param); 208 - return -EINVAL; 209 - } 210 - 211 222 static int tda665x_release(struct dvb_frontend *fe) 212 223 { 213 224 struct tda665x_state *state = fe->tuner_priv; ··· 207 240 } 208 241 209 242 static struct dvb_tuner_ops tda665x_ops = { 210 - 211 - .set_state = tda665x_set_state, 212 - .get_state = tda665x_get_state, 213 243 .get_status = tda665x_get_status, 214 244 .set_params = tda665x_set_params, 215 245 .get_frequency = tda665x_get_frequency,