Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

net/mlx5: Eliminate query xsrq dead code

1. This function is not used anywhere in mlx5 driver
2. It has a memcpy statement that makes no sense and produces build
warning with gcc8

drivers/net/ethernet/mellanox/mlx5/core/transobj.c: In function 'mlx5_core_query_xsrq':
drivers/net/ethernet/mellanox/mlx5/core/transobj.c:347:3: error: 'memcpy' source argument is the same as destination [-Werror=restrict]

Fixes: 01949d0109ee ("net/mlx5_core: Enable XRCs and SRQs when using ISSI > 0")
Reported-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Saeed Mahameed <saeedm@mellanox.com>

-22
-21
drivers/net/ethernet/mellanox/mlx5/core/transobj.c
··· 354 354 return mlx5_cmd_exec(dev, in, sizeof(in), out, sizeof(out)); 355 355 } 356 356 357 - int mlx5_core_query_xsrq(struct mlx5_core_dev *dev, u32 xsrqn, u32 *out) 358 - { 359 - u32 in[MLX5_ST_SZ_DW(query_xrc_srq_in)] = {0}; 360 - void *srqc; 361 - void *xrc_srqc; 362 - int err; 363 - 364 - MLX5_SET(query_xrc_srq_in, in, opcode, MLX5_CMD_OP_QUERY_XRC_SRQ); 365 - MLX5_SET(query_xrc_srq_in, in, xrc_srqn, xsrqn); 366 - err = mlx5_cmd_exec(dev, in, sizeof(in), out, 367 - MLX5_ST_SZ_BYTES(query_xrc_srq_out)); 368 - if (!err) { 369 - xrc_srqc = MLX5_ADDR_OF(query_xrc_srq_out, out, 370 - xrc_srq_context_entry); 371 - srqc = MLX5_ADDR_OF(query_srq_out, out, srq_context_entry); 372 - memcpy(srqc, xrc_srqc, MLX5_ST_SZ_BYTES(srqc)); 373 - } 374 - 375 - return err; 376 - } 377 - 378 357 int mlx5_core_arm_xsrq(struct mlx5_core_dev *dev, u32 xsrqn, u16 lwm) 379 358 { 380 359 u32 in[MLX5_ST_SZ_DW(arm_xrc_srq_in)] = {0};
-1
include/linux/mlx5/transobj.h
··· 67 67 int mlx5_core_create_xsrq(struct mlx5_core_dev *dev, u32 *in, int inlen, 68 68 u32 *rmpn); 69 69 int mlx5_core_destroy_xsrq(struct mlx5_core_dev *dev, u32 rmpn); 70 - int mlx5_core_query_xsrq(struct mlx5_core_dev *dev, u32 rmpn, u32 *out); 71 70 int mlx5_core_arm_xsrq(struct mlx5_core_dev *dev, u32 rmpn, u16 lwm); 72 71 73 72 int mlx5_core_create_rqt(struct mlx5_core_dev *dev, u32 *in, int inlen,