Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

firewire: replace tricky statement by two simple ones

struct fw_driver::remove returns void, still the comma expression's value
is zero. This is harder to parse than necessary, so replace the single
expression by two easier ones.

Signed-off-by: Uwe Kleine-König <uwe@kleine-koenig.org>
Link: https://lore.kernel.org/r/20210126221444.713837-1-uwe@kleine-koenig.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

authored by

Uwe Kleine-König and committed by
Greg Kroah-Hartman
b2c852f4 2adc75fb

+3 -1
+3 -1
drivers/firewire/core-device.c
··· 192 192 struct fw_driver *driver = 193 193 container_of(dev->driver, struct fw_driver, driver); 194 194 195 - return driver->remove(fw_unit(dev)), 0; 195 + driver->remove(fw_unit(dev)); 196 + 197 + return 0; 196 198 } 197 199 198 200 static int get_modalias(struct fw_unit *unit, char *buffer, size_t buffer_size)