Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

media: friio-fe: get rid of set_property()

This callback is not actually doing anything but making it to
return an error depending on the DTV frontend command. Well,
that could break userspace for no good reason, and, if needed,
should be implemented, instead, at set_frontend() callback.

So, get rid of it.

Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>

-24
-24
drivers/media/usb/dvb-usb/friio-fe.c
··· 261 261 return 0; 262 262 } 263 263 264 - 265 - /* filter out un-supported properties to notify users */ 266 - static int jdvbt90502_set_property(struct dvb_frontend *fe, 267 - struct dtv_property *tvp) 268 - { 269 - int r = 0; 270 - 271 - switch (tvp->cmd) { 272 - case DTV_DELIVERY_SYSTEM: 273 - if (tvp->u.data != SYS_ISDBT) 274 - r = -EINVAL; 275 - break; 276 - case DTV_CLEAR: 277 - case DTV_TUNE: 278 - case DTV_FREQUENCY: 279 - break; 280 - default: 281 - r = -EINVAL; 282 - } 283 - return r; 284 - } 285 - 286 264 static int jdvbt90502_set_frontend(struct dvb_frontend *fe) 287 265 { 288 266 struct dtv_frontend_properties *p = &fe->dtv_property_cache; ··· 434 456 435 457 .init = jdvbt90502_init, 436 458 .write = _jdvbt90502_write, 437 - 438 - .set_property = jdvbt90502_set_property, 439 459 440 460 .set_frontend = jdvbt90502_set_frontend, 441 461