Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

drm/panel: panel-edp: Use dev_err_probe() to simplify code

In the probe path, dev_err() can be replaced with dev_err_probe()
which will check if error code is -EPROBE_DEFER and prints the
error name. It also sets the defer probe reason which can be
checked later through debugfs.

Signed-off-by: Yuan Can <yuancan@huawei.com>
Reviewed-by: Douglas Anderson <dianders@chromium.org>
Signed-off-by: Douglas Anderson <dianders@chromium.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20220929015503.17301-2-yuancan@huawei.com
Link: https://patchwork.freedesktop.org/patch/msgid/20220929015503.17301-2-yuancan@huawei.com

authored by

Yuan Can and committed by
Douglas Anderson
b28d204a b55002b9

+6 -16
+6 -16
drivers/gpu/drm/panel/panel-edp.c
··· 403 403 404 404 static int panel_edp_get_hpd_gpio(struct device *dev, struct panel_edp *p) 405 405 { 406 - int err; 407 - 408 406 p->hpd_gpio = devm_gpiod_get_optional(dev, "hpd", GPIOD_IN); 409 - if (IS_ERR(p->hpd_gpio)) { 410 - err = PTR_ERR(p->hpd_gpio); 411 - 412 - if (err != -EPROBE_DEFER) 413 - dev_err(dev, "failed to get 'hpd' GPIO: %d\n", err); 414 - 415 - return err; 416 - } 407 + if (IS_ERR(p->hpd_gpio)) 408 + return dev_err_probe(dev, PTR_ERR(p->hpd_gpio), 409 + "failed to get 'hpd' GPIO\n"); 417 410 418 411 return 0; 419 412 } ··· 825 832 826 833 panel->enable_gpio = devm_gpiod_get_optional(dev, "enable", 827 834 GPIOD_OUT_LOW); 828 - if (IS_ERR(panel->enable_gpio)) { 829 - err = PTR_ERR(panel->enable_gpio); 830 - if (err != -EPROBE_DEFER) 831 - dev_err(dev, "failed to request GPIO: %d\n", err); 832 - return err; 833 - } 835 + if (IS_ERR(panel->enable_gpio)) 836 + return dev_err_probe(dev, PTR_ERR(panel->enable_gpio), 837 + "failed to request GPIO\n"); 834 838 835 839 err = of_drm_get_panel_orientation(dev->of_node, &panel->orientation); 836 840 if (err) {