Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

rtc: max77686: Fix the returned value in case of error in 'max77686_rtc_read_time()'

In case of error, we return 0.
This is spurious and not consistent with the other functions of the driver.
Commit e115a2bf1426 has modified more than what is said in the commit
message. Reverse part of it znd return an error when needed, as it was
previously.

Fixes: e115a2bf1426 ("rtc: max77686: stop validating rtc_time in .read_time")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>

authored by

Christophe JAILLET and committed by
Alexandre Belloni
b28cc6ce 50c8aec4

+1 -1
+1 -1
drivers/rtc/rtc-max77686.c
··· 360 360 361 361 out: 362 362 mutex_unlock(&info->lock); 363 - return 0; 363 + return ret; 364 364 } 365 365 366 366 static int max77686_rtc_set_time(struct device *dev, struct rtc_time *tm)